Linux-Crypto Archive on
 help / color / Atom feed
* [PATCH] crypto: algboss - don't wait during notifier callback
@ 2020-06-04 18:52 Eric Biggers
  2020-06-04 20:08 ` Eric Biggers
  2020-06-12  6:48 ` Herbert Xu
  0 siblings, 2 replies; 3+ messages in thread
From: Eric Biggers @ 2020-06-04 18:52 UTC (permalink / raw)
  To: linux-crypto, Herbert Xu; +Cc: stable, Martin K . Petersen, Mike Gerow

From: Eric Biggers <>

When a crypto template needs to be instantiated, CRYPTO_MSG_ALG_REQUEST
is sent to crypto_chain.  cryptomgr_schedule_probe() handles this by
starting a thread to instantiate the template, then waiting for this
thread to complete via crypto_larval::completion.

This can deadlock because instantiating the template may require loading
modules, and this (apparently depending on userspace) may need to wait
for the crc-t10dif module (lib/crc-t10dif.c) to be loaded.  But
crc-t10dif's module_init function uses crypto_register_notifier() and
therefore takes crypto_chain.rwsem for write.  That can't proceed until
the notifier callback has finished, as it holds this semaphore for read.

Fix this by removing the wait on crypto_larval::completion from within
cryptomgr_schedule_probe().  It's actually unnecessary because
crypto_alg_mod_lookup() calls crypto_larval_wait() itself after sending

This only actually became a problem in v4.20 due to commit b76377543b73
("crc-t10dif: Pick better transform if one becomes available"), but the
unnecessary wait was much older.

Reported-by: Mike Gerow <>
Fixes: 398710379f51 ("crypto: algapi - Move larval completion into algboss")
Cc: <> # v3.6+
Cc: Martin K. Petersen <>
Signed-off-by: Eric Biggers <>
 crypto/algboss.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/crypto/algboss.c b/crypto/algboss.c
index 535f1f87e6c1..5ebccbd6b74e 100644
--- a/crypto/algboss.c
+++ b/crypto/algboss.c
@@ -178,8 +178,6 @@ static int cryptomgr_schedule_probe(struct crypto_larval *larval)
 	if (IS_ERR(thread))
 		goto err_put_larval;
-	wait_for_completion_interruptible(&larval->completion);
 	return NOTIFY_STOP;

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-04 18:52 [PATCH] crypto: algboss - don't wait during notifier callback Eric Biggers
2020-06-04 20:08 ` Eric Biggers
2020-06-12  6:48 ` Herbert Xu

Linux-Crypto Archive on

Archives are clonable:
	git clone --mirror linux-crypto/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-crypto linux-crypto/ \
	public-inbox-index linux-crypto

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone