Linux-FSCrypt Archive on lore.kernel.org
 help / color / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Po-Hsu Lin <po-hsu.lin@canonical.com>
Cc: linux-fscrypt@vger.kernel.org
Subject: Re: [PATCH] Makefile: improve the cc-option compatibility
Date: Sat, 1 Aug 2020 11:12:00 -0700
Message-ID: <20200801181200.GB14666@sol.localdomain> (raw)
In-Reply-To: <CAMy_GT-JNP0aTM3wC2mniMrREGkHGHuc2G=4Wmj99AFXULa6hQ@mail.gmail.com>

On Thu, Jul 30, 2020 at 09:21:38PM +0800, Po-Hsu Lin wrote:
> BTW this is for fsverity-utils.
> 
> I should put a [fsverity-utils] in the title, sorry about this.
> I can resubmit one if you need.
> 
> Thank you
> PHLin
> 
> On Thu, Jul 30, 2020 at 5:35 PM Po-Hsu Lin <po-hsu.lin@canonical.com> wrote:
> >
> > The build on Ubuntu Xenial with GCC 5.4.0 will fail with:
> >     cc: error: unrecognized command line option ‘-Wimplicit-fallthrough’
> >
> > This unsupported flag is not skipped as expected.
> >
> > It is because of the /bin/sh shell on Ubuntu, DASH, which does not
> > support this &> redirection. Use 2>&1 to solve this problem.
> >
> > Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
> > ---
> >  Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Makefile b/Makefile
> > index 7d7247c..a4ce55a 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -27,7 +27,7 @@
> >  #
> >  ##############################################################################
> >
> > -cc-option = $(shell if $(CC) $(1) -c -x c /dev/null -o /dev/null &>/dev/null; \
> > +cc-option = $(shell if $(CC) $(1) -c -x c /dev/null -o /dev/null > /dev/null 2>&1; \
> >               then echo $(1); fi)
> >
> >  CFLAGS ?= -O2 -Wall -Wundef                                    \
> > --

Looks good, thanks!  I'll also want to add a test for building with dash to
scripts/run-tests.sh, but I can do that.

Note that we've just changed the license of fsverity-utils to the MIT license.
Can you rebase onto the latest master branch (commit ab794fd56511) and resend to
indicate that you agree?  And yes, I suggest "[fsverity-utils PATCH]", as this
mailing list is mostly used for kernel patches.  Thanks!

- Eric

  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-30  9:35 Po-Hsu Lin
2020-07-30 13:21 ` Po-Hsu Lin
2020-08-01 18:12   ` Eric Biggers [this message]
2020-08-03  3:09     ` Po-Hsu Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200801181200.GB14666@sol.localdomain \
    --to=ebiggers@kernel.org \
    --cc=linux-fscrypt@vger.kernel.org \
    --cc=po-hsu.lin@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-FSCrypt Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lkml.kernel.org/linux-fscrypt/0 linux-fscrypt/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-fscrypt linux-fscrypt/ https://lkml.kernel.org/linux-fscrypt \
		linux-fscrypt@vger.kernel.org
	public-inbox-index linux-fscrypt

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-fscrypt


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git