Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Matthew Wilcox <email@example.com>, firstname.lastname@example.org
Cc: email@example.com, firstname.lastname@example.org,
"Namjae Jeon" <email@example.com>,
"Sungjong Seo" <firstname.lastname@example.org>,
"Pali Rohár" <email@example.com>,
"Tetsuhiro Kohada" <firstname.lastname@example.org>,
"Wei Yongjun" <email@example.com>,
"Dan Carpenter" <firstname.lastname@example.org>
Subject: Re: exfat: add missing brelse() calls on error paths
Date: Wed, 10 Jun 2020 22:00:24 +0200 [thread overview]
Message-ID: <email@example.com> (raw)
> You're nitpicking commit messages.
I am occasionally trying to achieve corresponding improvements.
> This is exactly the kind of thing which drives people away.
Would you like to follow official patch process documentation?
> Dan's commit message is fine.
I have got the impression that he indicates another deviation from
a well-known requirement. I am curious under which circumstances
such a patch review concern will be taken into account finally.
> It's actually hilarious because your emails are so unclear that I
> can't understand them.
I find such feedback surprising and interesting.
I hope that we can reduce understanding difficulties together.
> I have no idea what "collateral evolution" means
This term expresses the situation that a single change can trigger
Examples for programmers:
* You add an argument to an used function.
* How many function calls will need related adjustments?
* Some function calls can fail.
* How do you think about to complete error detection and the
corresponding exception handling?
> and yet you use it in almost every email.
You exaggerate here.
> Why can't you use the same terminology the rest of us use?
I got also used to some wording approaches.
Which terminology variation do you prefer?
next prev parent reply other threads:[~2020-06-10 20:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 12:07 [PATCH] exfat: call brelse() on error path Markus Elfring
2020-06-10 17:22 ` [PATCH v2] exfat: add missing brelse() calls on error paths Dan Carpenter
2020-06-10 18:12 ` Markus Elfring
2020-06-10 18:45 ` Dan Carpenter
2020-06-10 18:56 ` Markus Elfring
2020-06-10 19:22 ` Matthew Wilcox
2020-06-10 20:00 ` Markus Elfring [this message]
2020-06-11 3:41 ` Namjae Jeon
2020-06-11 8:00 ` Markus Elfring
2020-06-11 8:40 ` Markus Elfring
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--subject='Re: exfat: add missing brelse() calls on error paths' \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).