Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: "Krzysztof Wilczyński" <kw@linux.com>,
	"Jeff Layton" <jlayton@kernel.org>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Matthew Wilcox <willy@infradead.org>,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v3] fs: Remove duplicated flag O_NDELAY occurring twice in VALID_OPEN_FLAGS
Date: Mon, 7 Sep 2020 10:46:01 -0600	[thread overview]
Message-ID: <01eef19a-a5f0-dbad-3091-dba05abb16c8@kernel.dk> (raw)
In-Reply-To: <20200906223949.62771-1-kw@linux.com>

On 9/6/20 4:39 PM, Krzysztof Wilczyński wrote:
> The O_NDELAY flag occurs twice in the VALID_OPEN_FLAGS definition, this
> change removes the duplicate.  There is no change to the functionality.
> 
> Note, that the flags O_NONBLOCK and O_NDELAY are not duplicates, as
> values of these flags are platform dependent, and on platforms like
> Sparc O_NONBLOCK and O_NDELAY are not the same.
> 
> This has been done that way to maintain the ABI compatibility with
> Solaris since the Sparc port was first introduced.
> 
> This change resolves the following Coccinelle warning:
> 
>   include/linux/fcntl.h:11:13-21: duplicated argument to & or |

Reviewed-by: Jens Axboe <axboe@kernel.dk>

-- 
Jens Axboe


  parent reply	other threads:[~2020-09-07 16:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-06 22:39 Krzysztof Wilczyński
2020-09-06 23:07 ` Matthew Wilcox
2020-09-07 16:46 ` Jens Axboe [this message]
2020-09-16 19:35 ` Krzysztof Wilczyński
2020-09-16 23:28   ` Al Viro
2020-09-18 16:16     ` Krzysztof Wilczyński

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01eef19a-a5f0-dbad-3091-dba05abb16c8@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=bfields@fieldses.org \
    --cc=jlayton@kernel.org \
    --cc=kw@linux.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    --subject='Re: [PATCH v3] fs: Remove duplicated flag O_NDELAY occurring twice in VALID_OPEN_FLAGS' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).