Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Tianxianting <tian.xianting@h3c.com>,
	"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fs: use correct parameter in notes of generic_file_llseek_size()
Date: Thu, 10 Sep 2020 19:57:24 -0700	[thread overview]
Message-ID: <07de1867-e61c-07fb-8809-91d5e573329b@infradead.org> (raw)
In-Reply-To: <3808373d663146c882c22397a1d6587f@h3c.com>

On 9/10/20 7:06 PM, Tianxianting wrote:
> Hi viro,
> Could I get your feedback?
> This patch fixed the build warning, I think it can be applied, thanks :) 
> 
> -----Original Message-----
> From: tianxianting (RD) 
> Sent: Saturday, September 05, 2020 3:15 PM
> To: viro@zeniv.linux.org.uk
> Cc: linux-fsdevel@vger.kernel.org; linux-kernel@vger.kernel.org; tianxianting (RD) <tian.xianting@h3c.com>
> Subject: [PATCH] fs: use correct parameter in notes of generic_file_llseek_size()
> 
> Fix warning when compiling with W=1:
> fs/read_write.c:88: warning: Function parameter or member 'maxsize' not described in 'generic_file_llseek_size'
> fs/read_write.c:88: warning: Excess function parameter 'size' description in 'generic_file_llseek_size'
> 
> Signed-off-by: Xianting Tian <tian.xianting@h3c.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  fs/read_write.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/read_write.c b/fs/read_write.c
> index 5db58b8c7..058563ee2 100644
> --- a/fs/read_write.c
> +++ b/fs/read_write.c
> @@ -71,7 +71,7 @@ EXPORT_SYMBOL(vfs_setpos);
>   * @file:	file structure to seek on
>   * @offset:	file offset to seek to
>   * @whence:	type of seek
> - * @size:	max size of this file in file system
> + * @maxsize:	max size of this file in file system
>   * @eof:	offset used for SEEK_END position
>   *
>   * This is a variant of generic_file_llseek that allows passing in a custom
> 


-- 
~Randy

  reply	other threads:[~2020-09-11  2:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-05  7:15 Xianting Tian
2020-09-11  2:06 ` Tianxianting
2020-09-11  2:57   ` Randy Dunlap [this message]
     [not found]     ` <e028ff27412d4a80aa273320482a801d@h3c.com>
2020-10-07 16:50       ` Randy Dunlap
2020-10-09  1:33         ` Tianxianting

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=07de1867-e61c-07fb-8809-91d5e573329b@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tian.xianting@h3c.com \
    --cc=viro@zeniv.linux.org.uk \
    --subject='Re: [PATCH] fs: use correct parameter in notes of generic_file_llseek_size()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).