Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Tetsuhiro Kohada <kohada.t2@gmail.com>
To: Sungjong Seo <sj1557.seo@samsung.com>
Cc: kohada.tetsuhiro@dc.mitsubishielectric.co.jp,
	mori.takahiro@ab.mitsubishielectric.co.jp,
	motai.hirotaka@aj.mitsubishielectric.co.jp,
	'Namjae Jeon' <namjae.jeon@samsung.com>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] exfat: remove EXFAT_SB_DIRTY flag
Date: Fri, 19 Jun 2020 13:22:21 +0900	[thread overview]
Message-ID: <0a93d1a1-dc34-f799-240e-843d7f021bbf@gmail.com> (raw)
In-Reply-To: <500801d64572$0bdd2940$23977bc0$@samsung.com>

>> I mentioned rmdir as an example.
>> However, this problem is not only with rmdirs.
>> VOL_DIRTY remains when some functions abort with an error.
>> In original, VOL_DIRTY is not cleared even if performe 'sync'.
>> With this patch, it ensures that VOL_DIRTY will be cleared by 'sync'.
>>
>> Is my description insufficient?
> 
> I understood what you said. However, it is a natural result
> when deleting the related code with EXFAT_SB_DIRTY flag.
> 
> So I thought it would be better to separate it into new problems
> related to VOL_DIRTY-set under not real errors.

I see.
It seems that it is better to consider separately when consistency is corrupted and when it is kept.

>> BTW
>> Even with this patch applied,  VOL_DIRTY remains until synced in the above
>> case.
>> It's not  easy to reproduce as rmdir, but I'll try to fix it in the future.
> 
> I think it's not a problem not to clear VOL_DIRTY under real errors,
> because VOL_DIRTY is just like a hint to note that write was not finished clearly.
> 
> If you mean there are more situation like ENOTEMPTY you mentioned,
> please make new patch to fix them.

Hmm.
VOL_DIRTY is easily cleared by another write operation.
For that purpose, I think MediaFailure is more appropriate.

BR
---
Tetsuhiro Kohada <kohada.t2@gmail.com>

  reply	other threads:[~2020-06-19  4:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200616021816epcas1p44b0833f14bbad0e25cc0efb27fb2ebd3@epcas1p4.samsung.com>
2020-06-16  2:18 ` Tetsuhiro Kohada
2020-06-16 23:55   ` Namjae Jeon
2020-06-17  7:20   ` Sungjong Seo
2020-06-17  8:41     ` Namjae Jeon
2020-06-18  8:36     ` Tetsuhiro Kohada
2020-06-18 13:11       ` Sungjong Seo
2020-06-19  4:22         ` Tetsuhiro Kohada [this message]
2020-07-10  7:36         ` Tetsuhiro Kohada
2020-08-08 17:47           ` Sungjong Seo
2020-08-12  9:19             ` Tetsuhiro Kohada
2020-08-13  4:03               ` Namjae Jeon
2020-08-18  1:20                 ` Tetsuhiro Kohada
2020-06-16  6:16 Markus Elfring
2020-06-16 14:45 ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a93d1a1-dc34-f799-240e-843d7f021bbf@gmail.com \
    --to=kohada.t2@gmail.com \
    --cc=kohada.tetsuhiro@dc.mitsubishielectric.co.jp \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mori.takahiro@ab.mitsubishielectric.co.jp \
    --cc=motai.hirotaka@aj.mitsubishielectric.co.jp \
    --cc=namjae.jeon@samsung.com \
    --cc=sj1557.seo@samsung.com \
    --subject='Re: [PATCH v3] exfat: remove EXFAT_SB_DIRTY flag' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).