Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH][next] fsinfo: fix an uninialized variable 'conn'
@ 2020-05-14 18:19 Colin King
  2020-05-19 16:15 ` David Howells
  0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2020-05-14 18:19 UTC (permalink / raw)
  To: David Howells, Alexander Viro, linux-fsdevel
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

Variable conn is not initialized and can potentially contain
garbage causing a false -EPERM return on the !conn check.
Fix this by initializing it to false.

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: f2494de388bd ("fsinfo: Add an attribute that lists all the visible mounts in a namespace")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 fs/namespace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/namespace.c b/fs/namespace.c
index 3fd24575756b..ae489cbac467 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -4433,7 +4433,7 @@ int fsinfo_generic_mount_all(struct path *path, struct fsinfo_context *ctx)
 	struct mnt_namespace *ns;
 	struct mount *m, *p;
 	struct path chroot;
-	bool conn;
+	bool conn = false;
 
 	m = real_mount(path->mnt);
 	ns = m->mnt_ns;
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH][next] fsinfo: fix an uninialized variable 'conn'
  2020-05-14 18:19 [PATCH][next] fsinfo: fix an uninialized variable 'conn' Colin King
@ 2020-05-19 16:15 ` David Howells
  0 siblings, 0 replies; 2+ messages in thread
From: David Howells @ 2020-05-19 16:15 UTC (permalink / raw)
  To: Colin King
  Cc: dhowells, Alexander Viro, linux-fsdevel, kernel-janitors, linux-kernel

Colin King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
> 
> Variable conn is not initialized and can potentially contain
> garbage causing a false -EPERM return on the !conn check.
> Fix this by initializing it to false.
> 
> Addresses-Coverity: ("Uninitialized scalar variable")
> Fixes: f2494de388bd ("fsinfo: Add an attribute that lists all the visible mounts in a namespace")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thanks, I've folded that in.

David


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-19 16:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-14 18:19 [PATCH][next] fsinfo: fix an uninialized variable 'conn' Colin King
2020-05-19 16:15 ` David Howells

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).