Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Nicholas Piggin <npiggin@gmail.com>
To: Dave Chinner <david@fromorbit.com>, Eric Biggers <ebiggers@kernel.org>
Cc: akpm@linux-foundation.org, Marco Elver <elver@google.com>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, "Paul E. McKenney" <paulmck@kernel.org>,
	syzbot <syzbot+0f1e470df6a4316e0a11@syzkaller.appspotmail.com>,
	syzkaller-bugs@googlegroups.com, Will Deacon <will@kernel.org>
Subject: Re: KCSAN: data-race in generic_file_buffered_read / generic_file_buffered_read
Date: Thu, 16 Jul 2020 16:24:01 +1000	[thread overview]
Message-ID: <1594880070.49b50i0a1p.astroid@bobo.none> (raw)
In-Reply-To: <20200716030357.GE1167@sol.localdomain>

Excerpts from Eric Biggers's message of July 16, 2020 1:03 pm:
> On Thu, Jul 16, 2020 at 09:42:03AM +1000, Dave Chinner wrote:
>> On Wed, Jul 15, 2020 at 09:32:56AM -0700, Eric Biggers wrote:
>> > [+Cc linux-fsdevel]
>> > 
>> > On Wed, Jul 15, 2020 at 05:29:12PM +0200, 'Marco Elver' via syzkaller-bugs wrote:
>> > > On Wed, Jul 15, 2020 at 08:16AM -0700, syzbot wrote:
>> > > > Hello,
>> > > > 
>> > > > syzbot found the following issue on:
>> > > > 
>> > > > HEAD commit:    e9919e11 Merge branch 'for-linus' of git://git.kernel.org/..
>> > > > git tree:       upstream
>> > > > console output: https://syzkaller.appspot.com/x/log.txt?x=1217a83b100000
>> > > > kernel config:  https://syzkaller.appspot.com/x/.config?x=570eb530a65cd98e
>> > > > dashboard link: https://syzkaller.appspot.com/bug?extid=0f1e470df6a4316e0a11
>> > > > compiler:       clang version 11.0.0 (https://github.com/llvm/llvm-project.git ca2dcbd030eadbf0aa9b660efe864ff08af6e18b)
>> > > > 
>> > > > Unfortunately, I don't have any reproducer for this issue yet.
>> > > > 
>> > > > IMPORTANT: if you fix the issue, please add the following tag to the commit:
>> > > > Reported-by: syzbot+0f1e470df6a4316e0a11@syzkaller.appspotmail.com
>> > > > 
>> > > > ==================================================================
>> > > > BUG: KCSAN: data-race in generic_file_buffered_read / generic_file_buffered_read
>> > > 
>> > > Our guess is that this is either misuse of an API from userspace, or a
>> > > bug. Can someone clarify?
>> > > 
>> > > Below are the snippets of code around these accesses.
>> > 
>> > Concurrent reads on the same file descriptor are allowed.  Not with sys_read(),
>> > as that implicitly uses the file position.  But it's allowed with sys_pread(),
>> > and also with sys_sendfile() which is the case syzbot is reporting here.
>> 
>> Concurrent read()s are fine, they'll just read from the same offset.
>> 
> 
> Actually the VFS serializes concurrent read()'s on the same fd, at least for
> regular files.

Hmm, where?

> Anyway, doesn't matter since we can consider pread() instead.
> 
>> 
>> > 
>> > > 
>> > > > write to 0xffff8880968747b0 of 8 bytes by task 6336 on cpu 0:
>> > > >  generic_file_buffered_read+0x18be/0x19e0 mm/filemap.c:2246
>> > > 
>> > > 	...
>> > > 	would_block:
>> > > 		error = -EAGAIN;
>> > > 	out:
>> > > 		ra->prev_pos = prev_index;
>> > > 		ra->prev_pos <<= PAGE_SHIFT;
>> > > 2246)		ra->prev_pos |= prev_offset;
>> > > 
>> > > 		*ppos = ((loff_t)index << PAGE_SHIFT) + offset;
>> > > 		file_accessed(filp);
>> > > 		return written ? written : error;
>> > > 	}
>> > > 	EXPORT_SYMBOL_GPL(generic_file_buffered_read);
>> > > 	...
>> > 
>> > Well, it's a data race.  Each open file descriptor has just one readahead state
>> > (struct file_ra_state), and concurrent reads of the same file descriptor
>> > use/change that readahead state without any locking.
>> > 
>> > Presumably this has traditionally been considered okay, since readahead is
>> > "only" for performance and doesn't affect correctness.  And for performance
>> > reasons, we want to avoid locking during file reads.
>> > 
>> > So we may just need to annotate all access to file_ra_state with
>> > READ_ONCE() and WRITE_ONCE()...
>> 
>> Please, no. Can we stop making the code hard to read, more difficult
>> to maintain and preventing the compiler from optimising it by doing
>> stupid "turn off naive static checker warnings" stuff like this?
>> 
>> If the code is fine with races, then -leave it alone-. If it's not
>> fine with a data race, then please go and work out the correct
>> ordering and place well documented barriers and/or release/acquire
>> ordering semantics in the code so that we do not need to hide data
>> races behind a compiler optimisation defeating macro....
>> 
>> Yes, I know data_race() exists to tell the tooling that it should
>> ignore data races in the expression, but that makes just as much
>> mess of the code as READ_ONCE/WRITE_ONCE being spewed everywhere
>> indiscriminately because <some tool said we need to do that>.
>> 
> 
> Data races are undefined behavior, so it's never guaranteed "fine".

Is this a new requirement for the kernel? Even code which is purely an 
optimisation (e.g. a readahead heuristic) can never be guaranteed to
be fine for a data race? As in, the compiler might be free to start
scribbling on memory because of undefined behaviour?

What we used to be able to do is assume that the variable might take on 
one or other value at any time its used (or even see split between the
two if the thing wasn't naturally aligned for example), but that was 
quite well "defined". So we could in fact guarantee that it would be 
fine.

> We can only
> attempt to conclude that it's fine "in practice" and is too difficult to fix,
> and therefore doesn't meet the bar to be fixed (for now).
> 
> Of course, in most cases the preferred solution for data races is to introduce
> proper synchronization.  As I said, I'm not sure that's feasible here.  Memory
> barriers aren't the issue here; we'd need *locking*, which would mean concurrent
> readers would start contending for the lock.  Other suggestions appreciated...


 		ra->prev_pos = prev_index;
 		ra->prev_pos <<= PAGE_SHIFT;
 2246)		ra->prev_pos |= prev_offset;


In this case we can do better I guess, in case some compiler decides to 
store a half-done calculation there because it ran out of registers.

WRITE_ONCE(ra->prev_pos, ((loff_t)prev_index << PAGE_SHIFT) | prev_offset);

As Dave said, adding WRITE_ONCE to the individual accesses would be 
stupid because it does nothing to solve the actual race and makes it 
harder to read in more than one way.

Thanks,
Nick

  reply	other threads:[~2020-07-16  6:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <0000000000004a4d6505aa7c688a@google.com>
     [not found] ` <20200715152912.GA2209203@elver.google.com>
2020-07-15 16:32   ` Eric Biggers
2020-07-15 16:45     ` Marco Elver
2020-07-15 23:42     ` Dave Chinner
2020-07-16  3:03       ` Eric Biggers
2020-07-16  6:24         ` Nicholas Piggin [this message]
2020-07-16  6:54           ` Eric Biggers
2020-07-16  7:52             ` Nicholas Piggin
2020-07-16 12:56               ` Marco Elver
2020-07-16 13:19             ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1594880070.49b50i0a1p.astroid@bobo.none \
    --to=npiggin@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@fromorbit.com \
    --cc=ebiggers@kernel.org \
    --cc=elver@google.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=paulmck@kernel.org \
    --cc=syzbot+0f1e470df6a4316e0a11@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=will@kernel.org \
    --subject='Re: KCSAN: data-race in generic_file_buffered_read / generic_file_buffered_read' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).