Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Jiri Kosina <trivial@kernel.org>, Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 23/29] fuse: Avoid comma separated statements
Date: Sat, 30 Jan 2021 11:04:00 -0800 [thread overview]
Message-ID: <15ab6a821b32d6fd4b49ee2037dc85e4ba6b08cc.camel@perches.com> (raw)
In-Reply-To: <1ccd477e845fe5a114960c6088612945e1a22f23.1598331149.git.joe@perches.com>
On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote:
> Use semicolons and braces.
ping?
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> fs/fuse/dir.c | 24 ++++++++++++++++--------
> 1 file changed, 16 insertions(+), 8 deletions(-)
>
> diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
> index 26f028bc760b..ecb6eed832a0 100644
> --- a/fs/fuse/dir.c
> +++ b/fs/fuse/dir.c
> @@ -1362,14 +1362,22 @@ static void iattr_to_fattr(struct fuse_conn *fc, struct iattr *iattr,
> {
> unsigned ivalid = iattr->ia_valid;
>
>
> - if (ivalid & ATTR_MODE)
> - arg->valid |= FATTR_MODE, arg->mode = iattr->ia_mode;
> - if (ivalid & ATTR_UID)
> - arg->valid |= FATTR_UID, arg->uid = from_kuid(fc->user_ns, iattr->ia_uid);
> - if (ivalid & ATTR_GID)
> - arg->valid |= FATTR_GID, arg->gid = from_kgid(fc->user_ns, iattr->ia_gid);
> - if (ivalid & ATTR_SIZE)
> - arg->valid |= FATTR_SIZE, arg->size = iattr->ia_size;
> + if (ivalid & ATTR_MODE) {
> + arg->valid |= FATTR_MODE;
> + arg->mode = iattr->ia_mode;
> + }
> + if (ivalid & ATTR_UID) {
> + arg->valid |= FATTR_UID;
> + arg->uid = from_kuid(fc->user_ns, iattr->ia_uid);
> + }
> + if (ivalid & ATTR_GID) {
> + arg->valid |= FATTR_GID;
> + arg->gid = from_kgid(fc->user_ns, iattr->ia_gid);
> + }
> + if (ivalid & ATTR_SIZE) {
> + arg->valid |= FATTR_SIZE;
> + arg->size = iattr->ia_size;
> + }
> if (ivalid & ATTR_ATIME) {
> arg->valid |= FATTR_ATIME;
> arg->atime = iattr->ia_atime.tv_sec;
next prev parent reply other threads:[~2021-01-30 19:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 4:55 [PATCH 00/29] treewide: Convert " Joe Perches
2020-08-25 4:56 ` [PATCH 23/29] fuse: Avoid " Joe Perches
2021-01-30 19:04 ` Joe Perches [this message]
2021-02-01 8:12 ` Miklos Szeredi
2020-09-09 2:09 ` [PATCH 00/29] treewide: Convert " Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15ab6a821b32d6fd4b49ee2037dc85e4ba6b08cc.camel@perches.com \
--to=joe@perches.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=trivial@kernel.org \
--subject='Re: [PATCH 23/29] fuse: Avoid comma separated statements' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).