Linux-Fsdevel Archive on
help / color / mirror / Atom feed
From: Hans de Goede <>
To: Arnd Bergmann <>,
	Greg Kroah-Hartman <>,
	Michael Thayer <>,
	Alexander Viro <>
Cc: Hans de Goede <>,
	Larry Finger <>,
	Christoph Hellwig <>,,
Subject: [PATCH v2 0/1] fs: Add VirtualBox guest shared folder (vboxsf) support
Date: Mon, 15 Jan 2018 18:51:15 +0100	[thread overview]
Message-ID: <> (raw)

Hi All,

Now that the vboxguest driver which the vboxsf (guest shared folder)
fs driver depends on is queued for merging into 4.16 in char-misc-next,
all the dependencies for the vboxsf are in place.

So here is a v2 of my initial vboxsf, addressing all of the remark from
Christoph Hellwig about v1:
 -Removed various unused wrapper functions
 -Don't use i_private, instead defined alloc_inode and destroy_inode
  methods and use container_of.
 -Drop obsolete comment referencing people to
 -move the single symlink op of from lnkops.c to file.c

As well as bunch of other cleanups:
 -Use SPDX license headers
 -Replace SHFLROOT / SHFLHANDLE defines with normal types
 -Removed unnecessary S_ISREG checks
 -Got rid of bounce_buffer in regops, instead add a "user" flag to 
  vboxsf_read / vboxsf_write, re-using the existing __user address support
  in the vboxguest module
 -Make vboxsf_wrappers return regular linux errno values
 -Use i_size_write to update size on writing
 -Convert doxygen style comments to kerneldoc style comments

Please review.



             reply	other threads:[~2018-01-15 17:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-15 17:51 Hans de Goede [this message]
2018-01-15 17:51 ` [PATCH v2] " Hans de Goede
2018-01-15 17:55   ` Christoph Hellwig
2018-01-15 18:01     ` Hans de Goede
2018-01-15 19:32   ` Amir Goldstein
2018-01-15 19:41     ` Hans de Goede
2018-01-15 20:22       ` Amir Goldstein
2018-01-15 22:36   ` Al Viro
2018-01-16 10:15     ` Hans de Goede
2018-01-17  3:19       ` Al Viro
2018-01-17 10:45         ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v2 0/1] fs: Add VirtualBox guest shared folder (vboxsf) support' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).