Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Michael Thayer <michael.thayer@oracle.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Hans de Goede <hdegoede@redhat.com>,
	Larry Finger <Larry.Finger@lwfinger.net>,
	Christoph Hellwig <hch@infradead.org>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: [PATCH v2 0/1] fs: Add VirtualBox guest shared folder (vboxsf) support
Date: Mon, 15 Jan 2018 18:51:15 +0100	[thread overview]
Message-ID: <20180115175116.4130-1-hdegoede@redhat.com> (raw)

Hi All,

Now that the vboxguest driver which the vboxsf (guest shared folder)
fs driver depends on is queued for merging into 4.16 in char-misc-next,
all the dependencies for the vboxsf are in place.

So here is a v2 of my initial vboxsf, addressing all of the remark from
Christoph Hellwig about v1:
 -Removed various unused wrapper functions
 -Don't use i_private, instead defined alloc_inode and destroy_inode
  methods and use container_of.
 -Drop obsolete comment referencing people to
  http://www.atnf.csiro.au/people/rgooch/linux/vfs.txt
 -move the single symlink op of from lnkops.c to file.c

As well as bunch of other cleanups:
 -Use SPDX license headers
 -Replace SHFLROOT / SHFLHANDLE defines with normal types
 -Removed unnecessary S_ISREG checks
 -Got rid of bounce_buffer in regops, instead add a "user" flag to 
  vboxsf_read / vboxsf_write, re-using the existing __user address support
  in the vboxguest module
 -Make vboxsf_wrappers return regular linux errno values
 -Use i_size_write to update size on writing
 -Convert doxygen style comments to kerneldoc style comments

Please review.

Regards,

Hans

             reply	other threads:[~2018-01-15 17:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-15 17:51 Hans de Goede [this message]
2018-01-15 17:51 ` [PATCH v2] " Hans de Goede
2018-01-15 17:55   ` Christoph Hellwig
2018-01-15 18:01     ` Hans de Goede
2018-01-15 19:32   ` Amir Goldstein
2018-01-15 19:41     ` Hans de Goede
2018-01-15 20:22       ` Amir Goldstein
2018-01-15 22:36   ` Al Viro
2018-01-16 10:15     ` Hans de Goede
2018-01-17  3:19       ` Al Viro
2018-01-17 10:45         ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180115175116.4130-1-hdegoede@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.thayer@oracle.com \
    --cc=viro@zeniv.linux.org.uk \
    --subject='Re: [PATCH v2 0/1] fs: Add VirtualBox guest shared folder (vboxsf) support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).