Linux-Fsdevel Archive on
help / color / mirror / Atom feed
From: Al Viro <>
To: Hans de Goede <>
Cc: Arnd Bergmann <>,
	Greg Kroah-Hartman <>,
	Michael Thayer <>,
	Larry Finger <>,
	Christoph Hellwig <>,,
Subject: Re: [PATCH v2] fs: Add VirtualBox guest shared folder (vboxsf) support
Date: Mon, 15 Jan 2018 22:36:45 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

* what hch said about mount options.  Get rid of that before the thing
  goes into mainline.

* all "inode = GET_F_DENTRY(f)->d_inode;" are complete BS; it's called
  file_inode(f).  Kill GET_F_DENTRY() off and be done with that.

* your ->rename() can race with ->get_link().  Look at the place where
  the former reassigns ->path and frees the old value and think what
  happens if the latter is called just prior to that kfree().

* the same goes for sf_inode_revalidate() vs. rename().

* just what happens to ->path of inode when e.g. its grandparent
  directory is renamed?

* AFAICS, you consider all negative dentries invalid.  Why do you even
  hash them, then?

  parent reply	other threads:[~2018-01-15 22:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-15 17:51 [PATCH v2 0/1] " Hans de Goede
2018-01-15 17:51 ` [PATCH v2] " Hans de Goede
2018-01-15 17:55   ` Christoph Hellwig
2018-01-15 18:01     ` Hans de Goede
2018-01-15 19:32   ` Amir Goldstein
2018-01-15 19:41     ` Hans de Goede
2018-01-15 20:22       ` Amir Goldstein
2018-01-15 22:36   ` Al Viro [this message]
2018-01-16 10:15     ` Hans de Goede
2018-01-17  3:19       ` Al Viro
2018-01-17 10:45         ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v2] fs: Add VirtualBox guest shared folder (vboxsf) support' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).