Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] staging: fanotify: remove prohibited space
@ 2018-01-17  4:58 Sidong Yang
  2018-01-17 14:11 ` Jan Kara
  0 siblings, 1 reply; 2+ messages in thread
From: Sidong Yang @ 2018-01-17  4:58 UTC (permalink / raw)
  To: Jan Kara; +Cc: Sidong Yang, Amir Goldstein, linux-fsdevel

Fix error reported by checkpatch.pl about space prohibited before
that close parenthesis ')'.

Signed-off-by: Sidong Yang <realwakka@gmail.com>
---
 fs/notify/fanotify/fanotify_user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/notify/fanotify/fanotify_user.c b/fs/notify/fanotify/fanotify_user.c
index d0d4bc4c4b70..291fe6800bce 100644
--- a/fs/notify/fanotify/fanotify_user.c
+++ b/fs/notify/fanotify/fanotify_user.c
@@ -38,7 +38,7 @@
 #define	FANOTIFY_INIT_ALL_EVENT_F_BITS				( \
 		O_ACCMODE	| O_APPEND	| O_NONBLOCK	| \
 		__O_SYNC	| O_DSYNC	| O_CLOEXEC     | \
-		O_LARGEFILE	| O_NOATIME	)
+		O_LARGEFILE	| O_NOATIME)
 
 extern const struct fsnotify_ops fanotify_fsnotify_ops;
 
-- 
2.11.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: fanotify: remove prohibited space
  2018-01-17  4:58 [PATCH] staging: fanotify: remove prohibited space Sidong Yang
@ 2018-01-17 14:11 ` Jan Kara
  0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2018-01-17 14:11 UTC (permalink / raw)
  To: Sidong Yang; +Cc: Jan Kara, Amir Goldstein, linux-fsdevel

On Wed 17-01-18 04:58:32, Sidong Yang wrote:
> Fix error reported by checkpatch.pl about space prohibited before
> that close parenthesis ')'.
> 
> Signed-off-by: Sidong Yang <realwakka@gmail.com>

Sorry, but this is just making checkpatch happy without looking too much at
the result. The indentation of FANOTIFY_INIT_ALL_EVENT_F_BITS definition is
such that braces are aligned with | operators. And, although it is somewhat
non-standard, it looks nice and better to me than the alternative suggested
by checkpatch. So won't apply this patch.

								Honza

> ---
>  fs/notify/fanotify/fanotify_user.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/notify/fanotify/fanotify_user.c b/fs/notify/fanotify/fanotify_user.c
> index d0d4bc4c4b70..291fe6800bce 100644
> --- a/fs/notify/fanotify/fanotify_user.c
> +++ b/fs/notify/fanotify/fanotify_user.c
> @@ -38,7 +38,7 @@
>  #define	FANOTIFY_INIT_ALL_EVENT_F_BITS				( \
>  		O_ACCMODE	| O_APPEND	| O_NONBLOCK	| \
>  		__O_SYNC	| O_DSYNC	| O_CLOEXEC     | \
> -		O_LARGEFILE	| O_NOATIME	)
> +		O_LARGEFILE	| O_NOATIME)
>  
>  extern const struct fsnotify_ops fanotify_fsnotify_ops;
>  
> -- 
> 2.11.0
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-01-17 14:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-17  4:58 [PATCH] staging: fanotify: remove prohibited space Sidong Yang
2018-01-17 14:11 ` Jan Kara

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).