From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:59914 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726150AbeLMPoU (ORCPT ); Thu, 13 Dec 2018 10:44:20 -0500 Date: Thu, 13 Dec 2018 09:44:17 -0600 From: Goldwyn Rodrigues To: Christoph Hellwig Cc: Avi Kivity , linux-fsdevel@vger.kernel.org, linux-aio@kvack.org Subject: Re: [PATCH] fs: Return EOPNOTSUPP if block layer does not support REQ_NOWAIT Message-ID: <20181213154417.uzuvlo5tceied2qu@merlin> References: <20181213115306.fm2mjc3qszjiwkgf@merlin> <38b8f7a9-cf95-e165-4e9a-40ddcfe6bed2@scylladb.com> <20181213142434.GA3239@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181213142434.GA3239@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 6:24 13/12, Christoph Hellwig wrote: > On Thu, Dec 13, 2018 at 02:04:41PM +0200, Avi Kivity wrote: > > On 12/13/18 1:53 PM, Goldwyn Rodrigues wrote: > > > For AIO+DIO with RWF_NOWAIT, if the block layer does not support REQ_NOWAIT, > > > it returns EIO. Return EOPNOTSUPP to represent the correct error code. > > > > > > Cc: stable@? > > > > > > > Signed-off-by: Goldwyn Rodrigues > > > --- > > > fs/direct-io.c | 11 +++++++---- > > > 1 file changed, 7 insertions(+), 4 deletions(-) > > > > > > diff --git a/fs/direct-io.c b/fs/direct-io.c > > > index 41a0e97252ae..77adf33916b8 100644 > > > --- a/fs/direct-io.c > > > +++ b/fs/direct-io.c > > > @@ -542,10 +542,13 @@ static blk_status_t dio_bio_complete(struct dio *dio, struct bio *bio) > > > blk_status_t err = bio->bi_status; > > > if (err) { > > I think this just need to become: > > if (err) > dio->io_error = blk_status_to_errno(bio->bi_status); > Ahh.. Din't of it's existence. Yes, the function is much more elaborate. Thanks! -- Goldwyn