From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:39016 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726453AbeLMTEr (ORCPT ); Thu, 13 Dec 2018 14:04:47 -0500 Date: Thu, 13 Dec 2018 13:04:43 -0600 From: Goldwyn Rodrigues To: Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, avi@scylladb.com Subject: Re: [PATCH] fs: Return EOPNOTSUPP if block layer does not support REQ_NOWAIT Message-ID: <20181213190443.3v6zlyxugfpbknck@merlin> References: <20181213115306.fm2mjc3qszjiwkgf@merlin> <20181213162718.GP6830@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181213162718.GP6830@bombadil.infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 8:27 13/12, Matthew Wilcox wrote: > On Thu, Dec 13, 2018 at 05:53:06AM -0600, Goldwyn Rodrigues wrote: > > For AIO+DIO with RWF_NOWAIT, if the block layer does not support REQ_NOWAIT, > > it returns EIO. Return EOPNOTSUPP to represent the correct error code. > > Why is EOPNOTSUPP the "correct" error code? That's a networking error, > not a block layer error. No. We return EOPNOTSUPP in filesystems as well, in case RWF_NOWAIT is not supported. -- Goldwyn