Linux-Fsdevel Archive on lore.kernel.org help / color / mirror / Atom feed
From: Johannes Thumshirn <jth@kernel.org> To: David Sterba <dsterba@suse.cz> Cc: linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, Eric Biggers <ebiggers@google.com>, Richard Weinberger <richard@nod.at>, Johannes Thumshirn <johannes.thumshirn@wdc.com>, Johannes Thumshirn <jthumshirn@suse.de> Subject: [PATCH v3 1/3] btrfs: rename btrfs_parse_device_options back to btrfs_parse_early_options Date: Thu, 14 May 2020 11:24:13 +0200 [thread overview] Message-ID: <20200514092415.5389-2-jth@kernel.org> (raw) In-Reply-To: <20200514092415.5389-1-jth@kernel.org> From: Johannes Thumshirn <johannes.thumshirn@wdc.com> As btrfs_parse_device_options() now doesn't only parse the -o device mount option but -o auth_key as well, it makes sense to rename it back to btrfs_parse_early_options(). This reverts commit fa59f27c8c35bbe00af8eff23de446a7f4b048b0. Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de> --- fs/btrfs/super.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c index 438ecba26557..07cec0d16348 100644 --- a/fs/btrfs/super.c +++ b/fs/btrfs/super.c @@ -482,8 +482,9 @@ int btrfs_parse_options(struct btrfs_fs_info *info, char *options, case Opt_subvolrootid: case Opt_device: /* - * These are parsed by btrfs_parse_subvol_options or - * btrfs_parse_device_options and can be ignored here. + * These are parsed by btrfs_parse_subvol_options + * and btrfs_parse_early_options + * and can be happily ignored here. */ break; case Opt_nodatasum: @@ -919,8 +920,9 @@ int btrfs_parse_options(struct btrfs_fs_info *info, char *options, * All other options will be parsed on much later in the mount process and * only when we need to allocate a new super block. */ -static int btrfs_parse_device_options(const char *options, fmode_t flags, - void *holder) +static int btrfs_parse_early_options(struct btrfs_fs_info *info, + const char *options, fmode_t flags, + void *holder) { substring_t args[MAX_OPT_ARGS]; char *device_name, *opts, *orig, *p; @@ -987,7 +989,7 @@ static int btrfs_parse_subvol_options(const char *options, char **subvol_name, /* * strsep changes the string, duplicate it because - * btrfs_parse_device_options gets called later + * btrfs_parse_early_options gets called later */ opts = kstrdup(options, GFP_KERNEL); if (!opts) @@ -1551,7 +1553,7 @@ static struct dentry *btrfs_mount_root(struct file_system_type *fs_type, } mutex_lock(&uuid_mutex); - error = btrfs_parse_device_options(data, mode, fs_type); + error = btrfs_parse_early_options(fs_info, data, mode, fs_type); if (error) { mutex_unlock(&uuid_mutex); goto error_fs_info; -- 2.26.1
next prev parent reply other threads:[~2020-05-14 9:24 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-14 9:24 [PATCH v3 0/3] Add file-system authentication to BTRFS Johannes Thumshirn 2020-05-14 9:24 ` Johannes Thumshirn [this message] 2020-05-14 9:24 ` [PATCH v3 2/3] btrfs: add authentication support Johannes Thumshirn 2020-05-27 13:24 ` David Sterba 2020-05-27 13:54 ` Johannes Thumshirn 2020-05-27 14:01 ` Johannes Thumshirn 2020-05-27 18:04 ` Johannes Thumshirn 2020-06-01 14:30 ` David Sterba 2020-06-01 14:35 ` David Sterba 2020-05-14 9:24 ` [PATCH v3 3/3] btrfs: document btrfs authentication Johannes Thumshirn 2020-05-14 12:26 ` Jonathan Corbet 2020-05-14 14:54 ` Johannes Thumshirn 2020-05-14 15:14 ` Richard Weinberger 2020-05-14 16:00 ` Jonathan Corbet 2020-05-14 16:05 ` Richard Weinberger 2020-05-24 19:55 ` David Sterba 2020-05-25 10:57 ` Johannes Thumshirn 2020-05-25 11:26 ` David Sterba 2020-05-25 11:44 ` Johannes Thumshirn 2020-05-25 13:10 ` [PATCH v3 0/3] Add file-system authentication to BTRFS David Sterba 2020-05-26 7:50 ` Johannes Thumshirn 2020-05-26 11:53 ` David Sterba 2020-05-26 12:44 ` Johannes Thumshirn 2020-06-01 14:59 ` David Sterba 2020-05-27 2:08 ` Qu Wenruo 2020-05-27 11:27 ` David Sterba 2020-05-27 11:58 ` Qu Wenruo 2020-05-27 13:11 ` David Sterba
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200514092415.5389-2-jth@kernel.org \ --to=jth@kernel.org \ --cc=dsterba@suse.cz \ --cc=ebiggers@google.com \ --cc=johannes.thumshirn@wdc.com \ --cc=jthumshirn@suse.de \ --cc=linux-btrfs@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=richard@nod.at \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).