Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: Xiaoming Ni <nixiaoming@huawei.com>
Cc: mcgrof@kernel.org, yzaikin@google.com, adobriyan@gmail.com,
mingo@kernel.org, peterz@infradead.org,
akpm@linux-foundation.org, yamada.masahiro@socionext.com,
bauerman@linux.ibm.com, gregkh@linuxfoundation.org,
skhan@linuxfoundation.org, dvyukov@google.com,
svens@stackframe.org, joel@joelfernandes.org, tglx@linutronix.de,
Jisheng.Zhang@synaptics.com, pmladek@suse.com,
bigeasy@linutronix.de, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, wangle6@huawei.com
Subject: Re: [PATCH 2/4] proc/sysctl: add shared variables -1
Date: Fri, 15 May 2020 09:05:23 -0700 [thread overview]
Message-ID: <202005150904.743BB3E52@keescook> (raw)
In-Reply-To: <88f3078b-9419-b9c6-e789-7d6e50ca2cef@huawei.com>
On Fri, May 15, 2020 at 05:06:28PM +0800, Xiaoming Ni wrote:
> On 2020/5/15 16:06, Kees Cook wrote:
> > On Fri, May 15, 2020 at 12:33:42PM +0800, Xiaoming Ni wrote:
> > > Add the shared variable SYSCTL_NEG_ONE to replace the variable neg_one
> > > used in both sysctl_writes_strict and hung_task_warnings.
> > >
> > > Signed-off-by: Xiaoming Ni <nixiaoming@huawei.com>
> > > ---
> > > fs/proc/proc_sysctl.c | 2 +-
> > > include/linux/sysctl.h | 1 +
> > > kernel/hung_task_sysctl.c | 3 +--
> > > kernel/sysctl.c | 3 +--
> >
> > How about doing this refactoring in advance of the extraction patch?
> Before advance of the extraction patch, neg_one is only used in one file,
> does it seem to have no value for refactoring?
I guess it doesn't matter much, but I think it's easier to review in the
sense that neg_one is first extracted and then later everything else is
moved.
--
Kees Cook
next prev parent reply other threads:[~2020-05-15 16:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 4:33 [PATCH 0/4] Move the sysctl interface to the corresponding feature code file Xiaoming Ni
2020-05-15 4:33 ` [PATCH 1/4] hung_task: Move hung_task sysctl interface to hung_task_sysctl.c Xiaoming Ni
2020-05-15 8:04 ` Kees Cook
2020-05-15 8:56 ` Xiaoming Ni
2020-05-15 16:03 ` Kees Cook
2020-05-15 20:21 ` Luis Chamberlain
2020-05-15 4:33 ` [PATCH 2/4] proc/sysctl: add shared variables -1 Xiaoming Ni
2020-05-15 8:06 ` Kees Cook
2020-05-15 9:06 ` Xiaoming Ni
2020-05-15 16:05 ` Kees Cook [this message]
2020-05-16 2:32 ` Xiaoming Ni
2020-05-16 2:47 ` Kees Cook
2020-05-16 3:05 ` Xiaoming Ni
2020-05-17 2:38 ` Kees Cook
2020-05-15 4:33 ` [PATCH 3/4] watchdog: move watchdog sysctl to watchdog.c Xiaoming Ni
2020-05-15 8:09 ` Kees Cook
2020-05-15 9:17 ` Xiaoming Ni
2020-05-15 4:33 ` [PATCH 4/4] sysctl: Add register_sysctl_init() interface Xiaoming Ni
2020-05-15 8:10 ` Kees Cook
2020-05-15 9:39 ` Xiaoming Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202005150904.743BB3E52@keescook \
--to=keescook@chromium.org \
--cc=Jisheng.Zhang@synaptics.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bauerman@linux.ibm.com \
--cc=bigeasy@linutronix.de \
--cc=dvyukov@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=joel@joelfernandes.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mingo@kernel.org \
--cc=nixiaoming@huawei.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=skhan@linuxfoundation.org \
--cc=svens@stackframe.org \
--cc=tglx@linutronix.de \
--cc=wangle6@huawei.com \
--cc=yamada.masahiro@socionext.com \
--cc=yzaikin@google.com \
--subject='Re: [PATCH 2/4] proc/sysctl: add shared variables -1' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).