Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Ira Weiny <ira.weiny@intel.com>
Cc: Andreas Dilger <adilger@dilger.ca>,
	Ext4 Developers List <linux-ext4@vger.kernel.org>,
	"Theodore Y. Ts'o" <tytso@mit.edu>, Jan Kara <jack@suse.cz>,
	Eric Biggers <ebiggers@kernel.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Dan Williams <dan.j.williams@intel.com>,
	Dave Chinner <david@fromorbit.com>,
	Christoph Hellwig <hch@lst.de>, Jeff Moyer <jmoyer@redhat.com>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Li Xi <lixi@ddn.com>
Subject: Re: [PATCH V3 7/8] fs/ext4: Introduce DAX inode flag
Date: Wed, 20 May 2020 13:55:09 -0700	[thread overview]
Message-ID: <20200520205509.GA17615@magnolia> (raw)
In-Reply-To: <20200520200242.GG3660833@iweiny-DESK2.sc.intel.com>

On Wed, May 20, 2020 at 01:02:42PM -0700, Ira Weiny wrote:
> On Wed, May 20, 2020 at 01:26:44PM -0600, Andreas Dilger wrote:
> > On May 19, 2020, at 11:57 PM, ira.weiny@intel.com wrote:
> > > 
> > > From: Ira Weiny <ira.weiny@intel.com>
> > > 
> > > Add a flag to preserve FS_XFLAG_DAX in the ext4 inode.
> > > 
> > > Set the flag to be user visible and changeable.  Set the flag to be
> > > inherited.  Allow applications to change the flag at any time with the
> > > exception of if VERITY or ENCRYPT is set.
> > > 
> > > Disallow setting VERITY or ENCRYPT if DAX is set.
> > > 
> > > Finally, on regular files, flag the inode to not be cached to facilitate
> > > changing S_DAX on the next creation of the inode.
> > > 
> > > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> > > 
> > > ---
> > > diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> > > index 6235440e4c39..467c30a789b6 100644
> > > --- a/fs/ext4/ext4.h
> > > +++ b/fs/ext4/ext4.h
> > > @@ -415,13 +415,16 @@ struct flex_groups {
> > > #define EXT4_VERITY_FL			0x00100000 /* Verity protected inode */
> > > #define EXT4_EA_INODE_FL	        0x00200000 /* Inode used for large EA */
> > > /* 0x00400000 was formerly EXT4_EOFBLOCKS_FL */
> > > +
> > > +#define EXT4_DAX_FL			0x01000000 /* Inode is DAX */
> > > +
> > > #define EXT4_INLINE_DATA_FL		0x10000000 /* Inode has inline data. */
> > > #define EXT4_PROJINHERIT_FL		0x20000000 /* Create with parents projid */
> > > #define EXT4_CASEFOLD_FL		0x40000000 /* Casefolded file */
> > > #define EXT4_RESERVED_FL		0x80000000 /* reserved for ext4 lib */
> > 
> > Hi Ira,
> > This flag value conflicts with the reserved flag in e2fsprogs for snapshots:
> > 
> > #define EXT4_SNAPFILE_FL                0x01000000  /* Inode is a snapshot */
> 
> Sure NP but is that new?  I'm building off of 5.7-rc4.
> 
> Just curious if I completely missed something.

Yeah, you missed that ... for some reason the kernel ext4 driver is
missing flags that are in e2fsprogs.  (huh??)

I would say you could probably just take over the flag because the 2010s
called and they don't want next3 back.  I guess that leaves 0x02000000
as the sole unclaimed bit, but this seriously needs some cleaning.

--D

> > 
> > Please change EXT4_DAX_FL and FS_DAX_FL to use 0x02000000, which is not used
> > for anything in either case.
> 
> NP, thanks!
> Ira
> 
> > 
> > Cheers, Andreas
> > 
> > 
> > > diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h
> > > index 379a612f8f1d..7c5f6eb51e2d 100644
> > > --- a/include/uapi/linux/fs.h
> > > +++ b/include/uapi/linux/fs.h
> > > @@ -262,6 +262,7 @@ struct fsxattr {
> > > #define FS_EA_INODE_FL			0x00200000 /* Inode used for large EA */
> > > #define FS_EOFBLOCKS_FL			0x00400000 /* Reserved for ext4 */
> > > #define FS_NOCOW_FL			0x00800000 /* Do not cow file */
> > > +#define FS_DAX_FL			0x01000000 /* Inode is DAX */
> > > #define FS_INLINE_DATA_FL		0x10000000 /* Reserved for ext4 */
> > > #define FS_PROJINHERIT_FL		0x20000000 /* Create with parents projid */
> > > #define FS_CASEFOLD_FL			0x40000000 /* Folder is case insensitive */
> > > --
> > > 2.25.1
> > > 
> > 
> > 
> > Cheers, Andreas
> > 
> > 
> > 
> > 
> > 
> 
> 

  reply	other threads:[~2020-05-20 20:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-20  5:57 [PATCH V3 0/8] Enable ext4 support for per-file/directory DAX operations ira.weiny
2020-05-20  5:57 ` [PATCH V3 1/8] fs/ext4: Narrow scope of DAX check in setflags ira.weiny
2020-05-20  5:57 ` [PATCH V3 2/8] fs/ext4: Disallow verity if inode is DAX ira.weiny
2020-05-20  5:57 ` [PATCH V3 3/8] fs/ext4: Change EXT4_MOUNT_DAX to EXT4_MOUNT_DAX_ALWAYS ira.weiny
2020-05-20  5:57 ` [PATCH V3 4/8] fs/ext4: Update ext4_should_use_dax() ira.weiny
2020-05-20 13:37   ` Jan Kara
2020-05-20 19:40     ` Ira Weiny
2020-05-21 10:24       ` Jan Kara
2020-05-20  5:57 ` [PATCH V3 5/8] fs/ext4: Only change S_DAX on inode load ira.weiny
2020-05-20  5:57 ` [PATCH V3 6/8] fs/ext4: Make DAX mount option a tri-state ira.weiny
2020-05-20  5:57 ` [PATCH V3 7/8] fs/ext4: Introduce DAX inode flag ira.weiny
2020-05-20 14:11   ` Jan Kara
2020-05-20 18:34     ` Ira Weiny
2020-05-20 19:26   ` Andreas Dilger
2020-05-20 20:02     ` Ira Weiny
2020-05-20 20:55       ` Darrick J. Wong [this message]
2020-05-21  0:57         ` Andreas Dilger
2020-05-20  5:57 ` [PATCH V3 8/8] Documentation/dax: Update DAX enablement for ext4 ira.weiny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200520205509.GA17615@magnolia \
    --to=darrick.wong@oracle.com \
    --cc=adilger@dilger.ca \
    --cc=dan.j.williams@intel.com \
    --cc=david@fromorbit.com \
    --cc=ebiggers@kernel.org \
    --cc=hch@lst.de \
    --cc=ira.weiny@intel.com \
    --cc=jack@suse.cz \
    --cc=jmoyer@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lixi@ddn.com \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    --subject='Re: [PATCH V3 7/8] fs/ext4: Introduce DAX inode flag' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).