Linux-Fsdevel Archive on
help / color / mirror / Atom feed
From: Dan Carpenter <>
To: Markus Elfring <>
	"Namjae Jeon" <>,
	"Sungjong Seo" <>,
	"Pali Rohár" <>,
	"Tetsuhiro Kohada" <>,
	"Wei Yongjun" <>
Subject: Re: [PATCH v2] exfat: add missing brelse() calls on error paths
Date: Wed, 10 Jun 2020 21:45:17 +0300	[thread overview]
Message-ID: <20200610184517.GC4282@kadam> (raw)
In-Reply-To: <>

On Wed, Jun 10, 2020 at 08:12:46PM +0200, Markus Elfring wrote:
> > If the second exfat_get_dentry() call fails then we need to release
> > "old_bh" before returning.  There is a similar bug in exfat_move_file().
> Would you like to convert any information from this change description
> into an imperative wording?

I really feel like imperative doesn't add anything.  I understand that
some people feel really strongly about it, but I don't know why.  It
doesn't make commit messages more understandable.

The important thing is that the problem is clear, the fix is clear and
the runtime impact is clear.

dan carpenter

  reply	other threads:[~2020-06-10 18:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-10 12:07 [PATCH] exfat: call brelse() on error path Markus Elfring
2020-06-10 17:22 ` [PATCH v2] exfat: add missing brelse() calls on error paths Dan Carpenter
2020-06-10 18:12   ` Markus Elfring
2020-06-10 18:45     ` Dan Carpenter [this message]
2020-06-10 18:56       ` Markus Elfring
2020-06-10 19:22         ` Matthew Wilcox
2020-06-10 20:00           ` Markus Elfring
2020-06-11  3:41   ` [PATCH v2] " Namjae Jeon
2020-06-11  8:00   ` Markus Elfring
2020-06-11  8:40   ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200610184517.GC4282@kadam \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v2] exfat: add missing brelse() calls on error paths' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).