Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] fs/fs-writeback.c: not WARN on unregistered BDI
@ 2020-06-11 7:22 Ming Lei
2020-06-11 7:27 ` Christoph Hellwig
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Ming Lei @ 2020-06-11 7:22 UTC (permalink / raw)
To: linux-fsdevel
Cc: Ming Lei, Alexander Viro, Christoph Hellwig, Brian Foster,
Dave Chinner, Jens Axboe, linux-block
BDI is unregistered from del_gendisk() which is usually done in device's
release handler from device hotplug or error handling context, so BDI
can be unregistered anytime.
It should be normal for __mark_inode_dirty to see un-registered BDI,
so kill the WARN().
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Brian Foster <bfoster@redhat.com>
Cc: Dave Chinner <dchinner@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
fs/fs-writeback.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index a605c3dddabc..5e718580d4bf 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -2318,10 +2318,6 @@ void __mark_inode_dirty(struct inode *inode, int flags)
wb = locked_inode_to_wb_and_lock_list(inode);
- WARN(bdi_cap_writeback_dirty(wb->bdi) &&
- !test_bit(WB_registered, &wb->state),
- "bdi-%s not registered\n", bdi_dev_name(wb->bdi));
-
inode->dirtied_when = jiffies;
if (dirtytime)
inode->dirtied_time_when = jiffies;
--
2.25.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] fs/fs-writeback.c: not WARN on unregistered BDI
2020-06-11 7:22 [PATCH] fs/fs-writeback.c: not WARN on unregistered BDI Ming Lei
@ 2020-06-11 7:27 ` Christoph Hellwig
2020-06-22 1:41 ` Ming Lei
2020-07-27 8:14 ` Ming Lei
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2020-06-11 7:27 UTC (permalink / raw)
To: Ming Lei
Cc: linux-fsdevel, Alexander Viro, Christoph Hellwig, Brian Foster,
Dave Chinner, Jens Axboe, linux-block
On Thu, Jun 11, 2020 at 03:22:51PM +0800, Ming Lei wrote:
> BDI is unregistered from del_gendisk() which is usually done in device's
> release handler from device hotplug or error handling context, so BDI
> can be unregistered anytime.
>
> It should be normal for __mark_inode_dirty to see un-registered BDI,
> so kill the WARN().
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fs/fs-writeback.c: not WARN on unregistered BDI
2020-06-11 7:22 [PATCH] fs/fs-writeback.c: not WARN on unregistered BDI Ming Lei
2020-06-11 7:27 ` Christoph Hellwig
@ 2020-06-22 1:41 ` Ming Lei
2020-07-27 8:14 ` Ming Lei
2 siblings, 0 replies; 4+ messages in thread
From: Ming Lei @ 2020-06-22 1:41 UTC (permalink / raw)
To: linux-fsdevel, Alexander Viro
Cc: Christoph Hellwig, Brian Foster, Dave Chinner, Jens Axboe, linux-block
On Thu, Jun 11, 2020 at 03:22:51PM +0800, Ming Lei wrote:
> BDI is unregistered from del_gendisk() which is usually done in device's
> release handler from device hotplug or error handling context, so BDI
> can be unregistered anytime.
>
> It should be normal for __mark_inode_dirty to see un-registered BDI,
> so kill the WARN().
>
> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Brian Foster <bfoster@redhat.com>
> Cc: Dave Chinner <dchinner@redhat.com>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: linux-block@vger.kernel.org
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
Hello Guys,
Ping...
Thanks,
Ming
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] fs/fs-writeback.c: not WARN on unregistered BDI
2020-06-11 7:22 [PATCH] fs/fs-writeback.c: not WARN on unregistered BDI Ming Lei
2020-06-11 7:27 ` Christoph Hellwig
2020-06-22 1:41 ` Ming Lei
@ 2020-07-27 8:14 ` Ming Lei
2 siblings, 0 replies; 4+ messages in thread
From: Ming Lei @ 2020-07-27 8:14 UTC (permalink / raw)
To: linux-fsdevel
Cc: Alexander Viro, Christoph Hellwig, Brian Foster, Dave Chinner,
Jens Axboe, linux-block, linux-kernel
On Thu, Jun 11, 2020 at 03:22:51PM +0800, Ming Lei wrote:
> BDI is unregistered from del_gendisk() which is usually done in device's
> release handler from device hotplug or error handling context, so BDI
> can be unregistered anytime.
>
> It should be normal for __mark_inode_dirty to see un-registered BDI,
> so kill the WARN().
>
> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Brian Foster <bfoster@redhat.com>
> Cc: Dave Chinner <dchinner@redhat.com>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: linux-block@vger.kernel.org
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> ---
> fs/fs-writeback.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index a605c3dddabc..5e718580d4bf 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -2318,10 +2318,6 @@ void __mark_inode_dirty(struct inode *inode, int flags)
>
> wb = locked_inode_to_wb_and_lock_list(inode);
>
> - WARN(bdi_cap_writeback_dirty(wb->bdi) &&
> - !test_bit(WB_registered, &wb->state),
> - "bdi-%s not registered\n", bdi_dev_name(wb->bdi));
> -
> inode->dirtied_when = jiffies;
> if (dirtytime)
> inode->dirtied_time_when = jiffies;
Hello Alexander,
Could you merge this patch if you are fine?
Thanks,
Ming
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-27 8:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-11 7:22 [PATCH] fs/fs-writeback.c: not WARN on unregistered BDI Ming Lei
2020-06-11 7:27 ` Christoph Hellwig
2020-06-22 1:41 ` Ming Lei
2020-07-27 8:14 ` Ming Lei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).