Linux-Fsdevel Archive on
help / color / mirror / Atom feed
From: Greg KH <>
To: Markus Elfring <>
Cc: Kaitao Cheng <>,,,,
	Alexey Dobriyan <>,
	Colin Ian King <>,
	Muchun Song <>
Subject: Re: [PATCH v2] proc/fd: Remove unnecessary variable initialisations in seq_show()
Date: Sun, 14 Jun 2020 09:12:35 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, Jun 12, 2020 at 06:45:57PM +0200, Markus Elfring wrote:
> > 'files' will be immediately reassigned. 'f_flags' and 'file' will be
> > overwritten in the if{} or seq_show() directly exits with an error.
> > so we don't need to consume CPU resources to initialize them.
> I suggest to improve also this change description.
> * Should the mentioned identifiers refer to variables?
> * Will another imperative wording be preferred?
> * I propose to extend the patch a bit more.
>   How do you think about to convert the initialisation for the variable “ret”
>   also into a later assignment?
> Regards,
> Markus


This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.


greg k-h's patch email bot

  parent reply	other threads:[~2020-06-14  7:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-12 16:09 [PATCH v2] proc/fd: Remove unnecessary {files, f_flags, file} initialization " Kaitao Cheng
2020-06-12 16:45 ` [PATCH v2] proc/fd: Remove unnecessary variable initialisations " Markus Elfring
2020-06-12 17:00   ` Matthew Wilcox
2020-06-12 17:03     ` Markus Elfring
2020-06-12 17:03     ` Markus Elfring
2020-06-12 17:04       ` Matthew Wilcox
2020-06-12 18:22         ` [v2] " Markus Elfring
2020-06-12 18:28           ` Matthew Wilcox
2020-06-12 18:43             ` Markus Elfring
2020-06-12 18:47               ` Matthew Wilcox
2020-06-12 19:00                 ` Markus Elfring
2020-06-12 19:00                 ` Markus Elfring
2020-06-12 19:02                   ` Matthew Wilcox
2020-06-12 19:49                   ` Al Viro
2020-06-14  7:12   ` Greg KH [this message]
2020-07-07  7:23 ` [PATCH v2] proc/fd: Adjust " Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v2] proc/fd: Remove unnecessary variable initialisations in seq_show()' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).