From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0C36C433DF for ; Mon, 22 Jun 2020 01:41:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 952EB22AAE for ; Mon, 22 Jun 2020 01:41:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KsOjwcS+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726651AbgFVBlW (ORCPT ); Sun, 21 Jun 2020 21:41:22 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:31566 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726529AbgFVBlW (ORCPT ); Sun, 21 Jun 2020 21:41:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592790081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=maTjhuPOCYI1RBgjCHgYVBP3U6NfJYTgjBB5thICW+A=; b=KsOjwcS+mzHlTZhjKzoxlgYfR2oWgXAGObHk8b/X1eFCzZSiBf67oywFliuYOdaIgHlObL B+xsMt4XxqBoYkBpNX/Ec2pBuD6GsddYqRIOMTyNVhR1vSzwsq6wQLILIJi1rgbn+QLefs 3ijp4IjmPCninSZD7MV5AIKJtc02AUk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-7-W3t0NUcjO-O85ICBmpvTGA-1; Sun, 21 Jun 2020 21:41:19 -0400 X-MC-Unique: W3t0NUcjO-O85ICBmpvTGA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BADC9107ACCD; Mon, 22 Jun 2020 01:41:17 +0000 (UTC) Received: from T590 (ovpn-12-19.pek2.redhat.com [10.72.12.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BF76D5C240; Mon, 22 Jun 2020 01:41:10 +0000 (UTC) Date: Mon, 22 Jun 2020 09:41:06 +0800 From: Ming Lei To: linux-fsdevel@vger.kernel.org, Alexander Viro Cc: Christoph Hellwig , Brian Foster , Dave Chinner , Jens Axboe , linux-block@vger.kernel.org Subject: Re: [PATCH] fs/fs-writeback.c: not WARN on unregistered BDI Message-ID: <20200622014106.GA795360@T590> References: <20200611072251.474246-1-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200611072251.474246-1-ming.lei@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Jun 11, 2020 at 03:22:51PM +0800, Ming Lei wrote: > BDI is unregistered from del_gendisk() which is usually done in device's > release handler from device hotplug or error handling context, so BDI > can be unregistered anytime. > > It should be normal for __mark_inode_dirty to see un-registered BDI, > so kill the WARN(). > > Cc: Alexander Viro > Cc: Christoph Hellwig > Cc: Brian Foster > Cc: Dave Chinner > Cc: Jens Axboe > Cc: linux-block@vger.kernel.org > Signed-off-by: Ming Lei Hello Guys, Ping... Thanks, Ming