Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Adrian Reber <firstname.lastname@example.org>
To: Christian Brauner <email@example.com>
Cc: "Eric Biederman" <firstname.lastname@example.org>,
"Pavel Emelyanov" <email@example.com>,
"Oleg Nesterov" <firstname.lastname@example.org>,
"Dmitry Safonov" <email@example.com>,
"Andrei Vagin" <firstname.lastname@example.org>,
"Nicolas Viennot" <Nicolas.Viennot@twosigma.com>,
"Michał Cłapiński" <email@example.com>,
"Kamil Yurtsever" <firstname.lastname@example.org>,
"Dirk Petersen" <email@example.com>,
"Christine Flood" <firstname.lastname@example.org>,
"Casey Schaufler" <email@example.com>,
"Mike Rapoport" <firstname.lastname@example.org>,
"Radostin Stoyanov" <email@example.com>,
"Cyrill Gorcunov" <firstname.lastname@example.org>,
"Serge Hallyn" <email@example.com>,
"Stephen Smalley" <firstname.lastname@example.org>,
"Sargun Dhillon" <email@example.com>,
"Arnd Bergmann" <firstname.lastname@example.org>,
"Eric Paris" <email@example.com>,
"Jann Horn" <firstname.lastname@example.org>,
Subject: Re: [PATCH v4 1/3] capabilities: Introduce CAP_CHECKPOINT_RESTORE
Date: Fri, 3 Jul 2020 13:11:13 +0200 [thread overview]
Message-ID: <20200703111113.GB243637@dcbz.redhat.com> (raw)
On Wed, Jul 01, 2020 at 10:27:08AM +0200, Christian Brauner wrote:
> On Wed, Jul 01, 2020 at 08:49:04AM +0200, Adrian Reber wrote:
> > This patch introduces CAP_CHECKPOINT_RESTORE, a new capability facilitating
> > checkpoint/restore for non-root users.
> > Over the last years, The CRIU (Checkpoint/Restore In Userspace) team has been
> > asked numerous times if it is possible to checkpoint/restore a process as
> > non-root. The answer usually was: 'almost'.
> > The main blocker to restore a process as non-root was to control the PID of the
> > restored process. This feature available via the clone3 system call, or via
> > /proc/sys/kernel/ns_last_pid is unfortunately guarded by CAP_SYS_ADMIN.
> > In the past two years, requests for non-root checkpoint/restore have increased
> > due to the following use cases:
> > * Checkpoint/Restore in an HPC environment in combination with a resource
> > manager distributing jobs where users are always running as non-root.
> > There is a desire to provide a way to checkpoint and restore long running
> > jobs.
> > * Container migration as non-root
> > * We have been in contact with JVM developers who are integrating
> > CRIU into a Java VM to decrease the startup time. These checkpoint/restore
> > applications are not meant to be running with CAP_SYS_ADMIN.
> > We have seen the following workarounds:
> > * Use a setuid wrapper around CRIU:
> > See https://github.com/FredHutch/slurm-examples/blob/master/checkpointer/lib/checkpointer/checkpointer-suid.c
> > * Use a setuid helper that writes to ns_last_pid.
> > Unfortunately, this helper delegation technique is impossible to use with
> > clone3, and is thus prone to races.
> > See https://github.com/twosigma/set_ns_last_pid
> > * Cycle through PIDs with fork() until the desired PID is reached:
> > This has been demonstrated to work with cycling rates of 100,000 PIDs/s
> > See https://github.com/twosigma/set_ns_last_pid
> > * Patch out the CAP_SYS_ADMIN check from the kernel
> > * Run the desired application in a new user and PID namespace to provide
> > a local CAP_SYS_ADMIN for controlling PIDs. This technique has limited use in
> > typical container environments (e.g., Kubernetes) as /proc is
> > typically protected with read-only layers (e.g., /proc/sys) for hardening
> > purposes. Read-only layers prevent additional /proc mounts (due to proc's
> > SB_I_USERNS_VISIBLE property), making the use of new PID namespaces limited as
> > certain applications need access to /proc matching their PID namespace.
> > The introduced capability allows to:
> > * Control PIDs when the current user is CAP_CHECKPOINT_RESTORE capable
> > for the corresponding PID namespace via ns_last_pid/clone3.
> > * Open files in /proc/pid/map_files when the current user is
> > CAP_CHECKPOINT_RESTORE capable in the root namespace, useful for recovering
> > files that are unreachable via the file system such as deleted files, or memfd
> > files.
> > See corresponding selftest for an example with clone3().
> > Signed-off-by: Adrian Reber <email@example.com>
> > Signed-off-by: Nicolas Viennot <Nicolas.Viennot@twosigma.com>
> > ---
> I think that now looks reasonable. A few comments.
> Before we proceed, please split the addition of
> checkpoint_restore_ns_capable() out into a separate patch.
> In fact, I think the cleanest way of doing this would be:
> - 0/n capability: add CAP_CHECKPOINT_RESTORE
> - 1/n pid: use checkpoint_restore_ns_capable() for set_tid
> - 2/n pid_namespace: use checkpoint_restore_ns_capable() for ns_last_pid
> - 3/n: proc: require checkpoint_restore_ns_capable() in init userns for map_files
> (commit subjects up to you of course) and a nice commit message for each
> time we relax a permissions on something so we have a clear separate
> track record for each change in case we need to revert something. Then
> the rest of the patches in this series. Testing patches probably last.
Yes, makes sense. I was thinking about this already, but I was not sure
if it I should do it or not. But I had the same idea already.
next prev parent reply other threads:[~2020-07-03 11:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 6:49 [PATCH v4 0/3] " Adrian Reber
2020-07-01 6:49 ` [PATCH v4 1/3] " Adrian Reber
2020-07-01 8:27 ` Christian Brauner
2020-07-03 11:11 ` Adrian Reber [this message]
2020-07-01 6:49 ` [PATCH v4 2/3] selftests: add clone3() CAP_CHECKPOINT_RESTORE test Adrian Reber
2020-07-02 20:53 ` Serge E. Hallyn
2020-07-03 11:18 ` Adrian Reber
2020-07-03 18:12 ` Serge E. Hallyn
2020-07-01 6:49 ` [PATCH v4 3/3] prctl: Allow ptrace capable processes to change /proc/self/exe Adrian Reber
2020-07-01 8:55 ` Christian Brauner
2020-07-02 21:58 ` Serge E. Hallyn
2020-07-02 21:16 ` Serge E. Hallyn
2020-07-02 22:00 ` Paul Moore
2020-07-06 17:13 ` Nicolas Viennot
2020-07-06 17:44 ` Christian Brauner
2020-07-07 15:45 ` Christian Brauner
2020-07-07 20:27 ` Cyrill Gorcunov
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--subject='Re: [PATCH v4 1/3] capabilities: Introduce CAP_CHECKPOINT_RESTORE' \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).