From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D709C433E0 for ; Wed, 8 Jul 2020 03:14:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DB70D20720 for ; Wed, 8 Jul 2020 03:14:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="jPcn8u79" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728878AbgGHDOw (ORCPT ); Tue, 7 Jul 2020 23:14:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728400AbgGHDOw (ORCPT ); Tue, 7 Jul 2020 23:14:52 -0400 Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3821C08C5E1 for ; Tue, 7 Jul 2020 20:14:50 -0700 (PDT) Received: by mail-pf1-x442.google.com with SMTP id z3so10033311pfn.12 for ; Tue, 07 Jul 2020 20:14:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oAwKqHK24P/HMH2S8nsQQ/C5A8edfnTk57osWeiH3rQ=; b=jPcn8u79M2ubqWOVgArEpIpOZmykPitfCUoGWRa6+qdIOI97B2U6jelnkbvjXAuChZ Z+MmJ0LdTQYzcxBmMKHTCKwjfciCn6vEWhb6CmddE9e2sdVlginnSJcI4hynjLkczzbl LS+umlChhWR4lhCrtRCR4GWrBQVV9t7/5Gyow= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oAwKqHK24P/HMH2S8nsQQ/C5A8edfnTk57osWeiH3rQ=; b=CLx7FJRnDKjov8r4z7SxqHcQLmQ3X4UCtXeRtjOHkVq0MpYg7e2pfcAM2XdBq/hqT1 i/Z6gi5ZKtRbjjRKZcS/wbtLOmIhUTP+uGD6UftIxwU12wl1XGwEO/aYME0EeBcbelK+ 8o540dDEKC/pfaeseJ3l+kER5mBXuroCJkuLwRx9zRD6qrTN9OGtwugfurN5QWfKQOzc cl9XUb/b2bYBtou7yTvS5WV8FxijyzLOqPMOaewFFHgtvxBFfICUVxxDuVMy+vEFfwul 0qOkRf54/Sj8l/Io4gO2cE7XH19YvxUiurR011TBiS9wCyeUEIDM0lbjedobKMJ+Ibr6 5OZw== X-Gm-Message-State: AOAM532IXjZ0ffPPAYy7E+IcmVRoD6eliUxb7wMwoHrA8f86ZT8gkZ7+ Pg2eIVEF40kc+XPunD145hcYbQ== X-Google-Smtp-Source: ABdhPJxhvCX833Au2SUtzVOGW9yxrRzRu1ollAu0zOyXR108vtcu6tLLUi/3fOYAAPRVVk6z2XGUHw== X-Received: by 2002:a65:6554:: with SMTP id a20mr41872771pgw.301.1594178090263; Tue, 07 Jul 2020 20:14:50 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id y7sm3665683pjp.47.2020.07.07.20.14.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 20:14:49 -0700 (PDT) Date: Tue, 7 Jul 2020 20:14:48 -0700 From: Kees Cook To: Scott Branden Cc: James Morris , Luis Chamberlain , Mimi Zohar , Greg Kroah-Hartman , "Rafael J. Wysocki" , Alexander Viro , Jessica Yu , Dmitry Kasatkin , "Serge E. Hallyn" , Casey Schaufler , "Eric W. Biederman" , Peter Zijlstra , Matthew Garrett , David Howells , Mauro Carvalho Chehab , Randy Dunlap , "Joel Fernandes (Google)" , KP Singh , Dave Olsthoorn , Hans de Goede , Peter Jones , Andrew Morton , Stephen Boyd , Paul Moore , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH 2/4] fs: Remove FIRMWARE_PREALLOC_BUFFER from kernel_read_file() enums Message-ID: <202007072011.91509B7C@keescook> References: <20200707081926.3688096-1-keescook@chromium.org> <20200707081926.3688096-3-keescook@chromium.org> <0a5e2c2e-507c-9114-5328-5943f63d707e@broadcom.com> <202007071447.D96AA42ECE@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Jul 07, 2020 at 08:06:23PM -0700, Scott Branden wrote: > Some people want the header files included in each c file they are used. > Others want header files not included if they are included in another header > file. Ah, yes. That's fine then, leave them in the .c files. -- Kees Cook