From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0DF7C433E0 for ; Wed, 8 Jul 2020 01:36:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC1F820786 for ; Wed, 8 Jul 2020 01:36:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594172168; bh=qcbZMOsf+PZnops4wxmQpE3tL1Fo9+d/2GUsJmsYjRc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=KaPNgvyfhwqdHAM/ghXVc04hR35dB/9J7hRfZHceAkD1AH4fmdgrLfCeHwSslAIEo 5V0xNqEwqJRxspKpVDtlJVJ1YhWIf+8xA52ErMbHtMm/QWRi2l9tIA6tr+e1lo+PRT Gn1DRa0EMICqUDUGyD/rvSfpH/B2kmxgywcXeBs8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728489AbgGHBgE (ORCPT ); Tue, 7 Jul 2020 21:36:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:48932 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728191AbgGHBgD (ORCPT ); Tue, 7 Jul 2020 21:36:03 -0400 Received: from sol.localdomain (c-107-3-166-239.hsd1.ca.comcast.net [107.3.166.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1B10C206DF; Wed, 8 Jul 2020 01:36:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594172163; bh=qcbZMOsf+PZnops4wxmQpE3tL1Fo9+d/2GUsJmsYjRc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pIPsXsDLGfJZLRa1uNPa8ep30GgD6VKtvrZTTnemio7/ps8+6BWHWzAWJQ3kgCdbJ SLzHPVMXTtzp7DK5m8QY5tcgIMCxcEwoJBid15CKOrWRwHBUsiwjH+7AtJ5wLO9ZZC c4Hzd9QK+N+6zgugVMC3ygDzISmy6Lm2tQYB99aE= Date: Tue, 7 Jul 2020 18:36:01 -0700 From: Eric Biggers To: Daniel Rosenberg Cc: Theodore Ts'o , linux-ext4@vger.kernel.org, Jaegeuk Kim , Chao Yu , linux-f2fs-devel@lists.sourceforge.net, linux-fscrypt@vger.kernel.org, Alexander Viro , Andreas Dilger , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Gabriel Krisman Bertazi , kernel-team@android.com Subject: Re: [PATCH v10 1/4] unicode: Add utf8_casefold_hash Message-ID: <20200708013601.GF839@sol.localdomain> References: <20200707113123.3429337-1-drosen@google.com> <20200707113123.3429337-2-drosen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200707113123.3429337-2-drosen@google.com> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Jul 07, 2020 at 04:31:20AM -0700, Daniel Rosenberg wrote: > This adds a case insensitive hash function to allow taking the hash > without needing to allocate a casefolded copy of the string. > > The existing d_hash implementations for casefolding allocates memory > within rcu-walk, by avoiding it we can be more efficient and avoid > worrying about a failed allocation. > > Signed-off-by: Daniel Rosenberg You can add: Reviewed-by: Eric Biggers If you have a chance please fix the grammar in the commit message though: "The existing d_hash implementations for casefolding allocate memory within rcu-walk. By avoiding this we can be more efficient and avoid worrying about a failed allocation." - Eric