Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
From: tytso@mit.edu
To: Satya Tangirala <satyat@google.com>
Cc: linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-ext4@vger.kernel.org, Eric Biggers <ebiggers@google.com>,
	Jaegeuk Kim <jaegeuk@kernel.org>
Subject: Re: [PATCH v4 2/4] fscrypt: add inline encryption support
Date: Wed, 8 Jul 2020 13:14:28 -0400	[thread overview]
Message-ID: <20200708171428.GE1627842@mit.edu> (raw)
In-Reply-To: <20200702015607.1215430-3-satyat@google.com>

On Thu, Jul 02, 2020 at 01:56:05AM +0000, Satya Tangirala wrote:
> Add support for inline encryption to fs/crypto/.  With "inline
> encryption", the block layer handles the decryption/encryption as part
> of the bio, instead of the filesystem doing the crypto itself via
> Linux's crypto API. This model is needed in order to take advantage of
> the inline encryption hardware present on most modern mobile SoCs.
> 
> To use inline encryption, the filesystem needs to be mounted with
> '-o inlinecrypt'. Blk-crypto will then be used instead of the traditional
> filesystem-layer crypto whenever possible to encrypt the contents
> of any encrypted files in that filesystem. Fscrypt still provides the key
> and IV to use, and the actual ciphertext on-disk is still the same;
> therefore it's testable using the existing fscrypt ciphertext verification
> tests.
> 
> Note that since blk-crypto has a fallback to Linux's crypto API, and
> also supports all the encryption modes currently supported by fscrypt,
> this feature is usable and testable even without actual inline
> encryption hardware.
> 
> Per-filesystem changes will be needed to set encryption contexts when
> submitting bios and to implement the 'inlinecrypt' mount option.  This
> patch just adds the common code.
> 
> Co-developed-by: Eric Biggers <ebiggers@google.com>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> Signed-off-by: Satya Tangirala <satyat@google.com>
> Reviewed-by: Jaegeuk Kim <jaegeuk@kernel.org>
> Reviewed-by: Eric Biggers <ebiggers@google.com>

Reviewed-by: Theodore Ts'o <tytso@mit.edu>

  reply	other threads:[~2020-07-08 17:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-02  1:56 [PATCH v4 0/4] Inline Encryption Support for fscrypt Satya Tangirala
2020-07-02  1:56 ` [PATCH v4 1/4] fs: introduce SB_INLINECRYPT Satya Tangirala
2020-07-08 17:07   ` tytso
2020-07-02  1:56 ` [PATCH v4 2/4] fscrypt: add inline encryption support Satya Tangirala
2020-07-08 17:14   ` tytso [this message]
2020-07-02  1:56 ` [PATCH v4 3/4] f2fs: " Satya Tangirala
2020-07-02  1:56 ` [PATCH v4 4/4] ext4: " Satya Tangirala
2020-07-08 17:18   ` tytso
2020-07-08 17:34     ` Eric Biggers
2020-07-07 18:08 ` [PATCH v4 0/4] Inline Encryption Support for fscrypt Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200708171428.GE1627842@mit.edu \
    --to=tytso@mit.edu \
    --cc=ebiggers@google.com \
    --cc=jaegeuk@kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fscrypt@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=satyat@google.com \
    --subject='Re: [PATCH v4 2/4] fscrypt: add inline encryption support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).