From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=vItX=AY=vger.kernel.org=linux-fsdevel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID,
	DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id DCB3AC433E2
	for <linux-fsdevel@archiver.kernel.org>; Mon, 13 Jul 2020 11:59:49 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id AB6D52072D
	for <linux-fsdevel@archiver.kernel.org>; Mon, 13 Jul 2020 11:59:49 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="loRHfCGf"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729027AbgGML7t (ORCPT
        <rfc822;linux-fsdevel@archiver.kernel.org>);
        Mon, 13 Jul 2020 07:59:49 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32908 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728382AbgGML7t (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Mon, 13 Jul 2020 07:59:49 -0400
Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2C78C061755
        for <linux-fsdevel@vger.kernel.org>; Mon, 13 Jul 2020 04:59:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=zc1wyjmwUyNjlkanvz8p/hKZVnLJCywS7UkZaCHJfbE=; b=loRHfCGfv+HLZsoTw7sELq8rgp
        Rd1n+rFlsPiNoVhPbOR4YE0GRResyHIT5xtshRVR5sO5IyPfFajSxGZYLQyFH32CfvCpm4YsI1JVd
        hmnjSjlNZBaiBdFtCyC3hgTu56+qsyZGc2o0XXZQss7ZeLZ1gVhoeLhKA2YDaQSIGk6uYs3GFXHhB
        zCTik8rl//hJ0foVUBmvPCdJOUzMT/Zeyk4kF70Was9ppG2EuQ+zsWdD2gE427Ny+zT5u9321JbuW
        A/sejfp9Z684nHJMcSAyHOTsiiP7Oln46nxFYHssYvRHSbaoEKZwD0g+8CjFCT2oryc1TqSL8W40D
        PisA1Jkw==;
Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux))
        id 1jux7b-0004pp-5F; Mon, 13 Jul 2020 11:59:47 +0000
Date:   Mon, 13 Jul 2020 12:59:47 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     linux-fsdevel@vger.kernel.org,
        Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] fs: define inode flags using bit numbers
Message-ID: <20200713115947.GX12769@casper.infradead.org>
References: <20200713030952.192348-1-ebiggers@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200713030952.192348-1-ebiggers@kernel.org>
Sender: linux-fsdevel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-fsdevel.vger.kernel.org>
X-Mailing-List: linux-fsdevel@vger.kernel.org

On Sun, Jul 12, 2020 at 08:09:52PM -0700, Eric Biggers wrote:
> Define the VFS inode flags using bit numbers instead of hardcoding
> powers of 2, which has become unwieldy now that we're up to 65536.

If you're going to change these, why not use the BIT() macro?