Linux-Fsdevel Archive on
help / color / mirror / Atom feed
From: Eric Biggers <>
To: Christoph Hellwig <>
Cc: Satya Tangirala <>,,,,
Subject: Re: [PATCH 2/5] direct-io: add support for fscrypt using blk-crypto
Date: Mon, 13 Jul 2020 11:36:19 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, Jul 10, 2020 at 06:34:06AM +0100, Christoph Hellwig wrote:
> On Thu, Jul 09, 2020 at 07:47:48PM +0000, Satya Tangirala wrote:
> > From: Eric Biggers <>
> > 
> > Set bio crypt contexts on bios by calling into fscrypt when required,
> > and explicitly check for DUN continuity when adding pages to the bio.
> > (While DUN continuity is usually implied by logical block contiguity,
> > this is not the case when using certain fscrypt IV generation methods
> > like IV_INO_LBLK_32).
> I know it is asking you for more work, but instead of adding more
> features to the legacy direct I/O code, could you just switch the user
> of it (I guess this is for f2f2?) to the iomap one?

Eventually we should do that, as well as convert f2fs's fiemap, bmap, and llseek
to use iomap.  However there's a nontrivial barrier to entry, at least for
someone who isn't an expert in iomap, especially since f2fs currently doesn't
use iomap at all and thus doesn't have an iomap_ops implementation.  And using
ext4 as an example, there will be some subtle cases that need to be handled.

Satya says he's looking into it; we'll see what he can come up with and what the
f2fs developers say.

If it turns out to be difficult and people think this patchset is otherwise
ready, we probably shouldn't hold it up on that.  This is a very small patch,
and Satya and I have to maintain it for years in downstream kernels anyway, so
it will be used and tested regardless.  It would also be nice to allow userspace
(e.g. xfstests) to assume that if the inlinecrypt mount option is supported,
then direct I/O is supported too, without having to handle intermediate kernel
releases where inlinecrypt was supported but not direct I/O.

- Eric

  reply	other threads:[~2020-07-13 18:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-09 19:47 [PATCH 0/5] add support for direct I/O with " Satya Tangirala
2020-07-09 19:47 ` [PATCH 1/5] fscrypt: Add functions for direct I/O support Satya Tangirala
2020-07-09 21:54   ` Eric Biggers
2020-07-09 19:47 ` [PATCH 2/5] direct-io: add support for fscrypt using blk-crypto Satya Tangirala
2020-07-10  5:34   ` Christoph Hellwig
2020-07-13 18:36     ` Eric Biggers [this message]
2020-07-17  1:56       ` Satya Tangirala
2020-07-09 19:47 ` [PATCH 3/5] iomap: support direct I/O with " Satya Tangirala
2020-07-09 21:59   ` Eric Biggers
2020-07-09 19:47 ` [PATCH 4/5] ext4: " Satya Tangirala
2020-07-09 22:30   ` Eric Biggers
2020-07-09 19:47 ` [PATCH 5/5] f2fs: " Satya Tangirala
2020-07-10  1:05   ` Chao Yu
2020-07-10  1:15     ` Eric Biggers
2020-07-09 22:46 ` [PATCH 0/5] add support for " Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH 2/5] direct-io: add support for fscrypt using blk-crypto' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).