From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE702C433E7 for ; Wed, 15 Jul 2020 20:38:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC26720672 for ; Wed, 15 Jul 2020 20:38:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ijKpH2WT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727075AbgGOUis (ORCPT ); Wed, 15 Jul 2020 16:38:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726370AbgGOUir (ORCPT ); Wed, 15 Jul 2020 16:38:47 -0400 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECF22C061755 for ; Wed, 15 Jul 2020 13:38:46 -0700 (PDT) Received: by mail-pf1-x444.google.com with SMTP id x72so2612942pfc.6 for ; Wed, 15 Jul 2020 13:38:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=qTkObtIP1JOxTsAafQAu4JRP/2PqoQenw/nsfCYT+XA=; b=ijKpH2WTKasm1SeJa7YfW41RoND4SGhxfWW8WIrBUyWAJo5mncDz3F6DsdpLNbN9yM zimIQJdAwdsoIuaoAmdGi8bqgFGbI1ImDdJTj84SXvxwzifKGWR/ToGmegNpJJRYxabz 0Mzoe5AOfjDlUoukmWy/DGwdgH+42OpxYqawc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=qTkObtIP1JOxTsAafQAu4JRP/2PqoQenw/nsfCYT+XA=; b=SpDMZyeVKqbEqRA+XwPpS1NOQ79zkdPY5JItG4FyIl0W5U/efUxpJ3MrbalYhOGVdc ke4qfUebwzTXv2Rab97dFrMuMxFJ1GcuhV3nHyeOUR23maGnnQJE9PZTVwP13L3uVY9i gBeuIwnxkM25geCwOZqtfITezC1NxzAQX0hm28Nuz+JG+wP0PtZP8oJ8ET7JnXAFri8S xZSfwMuV803c+XBUQJs6j6r8lB52Fv522lmIePjmc6uE9LJjcANVqYAUKf0y44KNNZfl iV6cmFFdZblftmio0/YM0b0PvSoUYQWKJzO3fofY87SAvQXJK6BiHmUQTueumQQMNgzo W09Q== X-Gm-Message-State: AOAM531QAxjI1HGTn9HAdquCdPMYceVc8ndZVP/dw9O94KvmtijzyeZi bySih943moXo3nfo7YNpI1He0w== X-Google-Smtp-Source: ABdhPJyOe9mUdiu/xb+eBR+7MVDzMD0v9uEBAElvlLK4fUJtk8fgRzbG6NWh1tQpT587gudq9JBjRg== X-Received: by 2002:a62:cdc4:: with SMTP id o187mr922387pfg.200.1594845526528; Wed, 15 Jul 2020 13:38:46 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id m3sm2962482pfk.171.2020.07.15.13.38.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2020 13:38:45 -0700 (PDT) Date: Wed, 15 Jul 2020 13:38:44 -0700 From: Kees Cook To: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= Cc: linux-kernel@vger.kernel.org, Aleksa Sarai , Alexei Starovoitov , Al Viro , Andrew Morton , Andy Lutomirski , Christian Brauner , Christian Heimes , Daniel Borkmann , Deven Bowers , Dmitry Vyukov , Eric Biggers , Eric Chiang , Florian Weimer , James Morris , Jan Kara , Jann Horn , Jonathan Corbet , Lakshmi Ramasubramanian , Matthew Garrett , Matthew Wilcox , Michael Kerrisk , =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Mimi Zohar , Philippe =?iso-8859-1?Q?Tr=E9buchet?= , Scott Shell , Sean Christopherson , Shuah Khan , Steve Dower , Steve Grubb , Tetsuo Handa , Thibaut Sautereau , Vincent Strubel , kernel-hardening@lists.openwall.com, linux-api@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v6 6/7] selftest/openat2: Add tests for O_MAYEXEC enforcing Message-ID: <202007151337.2A113F8C@keescook> References: <20200714181638.45751-1-mic@digikod.net> <20200714181638.45751-7-mic@digikod.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200714181638.45751-7-mic@digikod.net> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Jul 14, 2020 at 08:16:37PM +0200, Mickaël Salaün wrote: > Test propagation of noexec mount points or file executability through > files open with or without O_MAYEXEC, thanks to the > fs.open_mayexec_enforce sysctl. > > Signed-off-by: Mickaël Salaün > Reviewed-by: Thibaut Sautereau > Cc: Aleksa Sarai > Cc: Al Viro > Cc: Kees Cook > Cc: Shuah Khan Yay variants! :) Reviewed-by: Kees Cook -- Kees Cook