Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 5.7 1/1] fuse: fix weird page warning
@ 2020-07-21 18:54 André Almeida
  2020-07-22 20:39 ` Sasha Levin
  0 siblings, 1 reply; 2+ messages in thread
From: André Almeida @ 2020-07-21 18:54 UTC (permalink / raw)
  To: linux-kernel, stable
  Cc: kernel, linux-fsdevel, gregkh, sashal, krisman,
	André Almeida, Nikolaus Rath, Hugh Dickins, Miklos Szeredi

From: Miklos Szeredi <mszeredi@redhat.com>

commit a5005c3cda6eeb6b95645e6cc32f58dafeffc976 upstream.

When PageWaiters was added, updating this check was missed.

Reported-by: Nikolaus Rath <Nikolaus@rath.org>
Reported-by: Hugh Dickins <hughd@google.com>
Fixes: 62906027091f ("mm: add PageWaiters indicating tasks are waiting for a page bit")
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Signed-off-by: André Almeida <andrealmeid@collabora.com>
---
 fs/fuse/dev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c
index 5c155437a455..ec02c3240176 100644
--- a/fs/fuse/dev.c
+++ b/fs/fuse/dev.c
@@ -771,7 +771,8 @@ static int fuse_check_page(struct page *page)
 	       1 << PG_uptodate |
 	       1 << PG_lru |
 	       1 << PG_active |
-	       1 << PG_reclaim))) {
+	       1 << PG_reclaim |
+	       1 << PG_waiters))) {
 		pr_warn("trying to steal weird page\n");
 		pr_warn("  page=%p index=%li flags=%08lx, count=%i, mapcount=%i, mapping=%p\n", page, page->index, page->flags, page_count(page), page_mapcount(page), page->mapping);
 		return 1;
-- 
2.27.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 5.7 1/1] fuse: fix weird page warning
  2020-07-21 18:54 [PATCH 5.7 1/1] fuse: fix weird page warning André Almeida
@ 2020-07-22 20:39 ` Sasha Levin
  0 siblings, 0 replies; 2+ messages in thread
From: Sasha Levin @ 2020-07-22 20:39 UTC (permalink / raw)
  To: André Almeida
  Cc: linux-kernel, stable, kernel, linux-fsdevel, gregkh, krisman,
	Nikolaus Rath, Hugh Dickins, Miklos Szeredi

On Tue, Jul 21, 2020 at 03:54:59PM -0300, André Almeida wrote:
>From: Miklos Szeredi <mszeredi@redhat.com>
>
>commit a5005c3cda6eeb6b95645e6cc32f58dafeffc976 upstream.
>
>When PageWaiters was added, updating this check was missed.
>
>Reported-by: Nikolaus Rath <Nikolaus@rath.org>
>Reported-by: Hugh Dickins <hughd@google.com>
>Fixes: 62906027091f ("mm: add PageWaiters indicating tasks are waiting for a page bit")
>Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
>Signed-off-by: André Almeida <andrealmeid@collabora.com>

Queued for 5.7-4.19, thanks!

-- 
Thanks,
Sasha

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-07-22 20:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-21 18:54 [PATCH 5.7 1/1] fuse: fix weird page warning André Almeida
2020-07-22 20:39 ` Sasha Levin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).