Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
* [QUESTION] Sharing a `struct page` across multiple `struct address_space` instances
@ 2020-07-25  0:22 Vito Caputo
  2020-07-25  3:11 ` Matthew Wilcox
  0 siblings, 1 reply; 3+ messages in thread
From: Vito Caputo @ 2020-07-25  0:22 UTC (permalink / raw)
  To: linux-kernel; +Cc: linux-fsdevel, Dave Chinner

Hello folks,

I've been poking around the shmem/tmpfs code with an eye towards
adding reflink support to tmpfs.

Prior to looking at the code, conceptually I was envisioning the pages
in the reflink source inode's address_space would simply get their
refcounts bumped as they were added to the dest inode's address_space,
with some CoW flag set to prevent writes.

But there seems to be a fundamental assumption that a `struct page`
would only belong to a single `struct address_space` at a time, as it
has single `mapping` and `index` members for reverse mapping the page
to its address_space.

Am I completely lost here or does it really look like a rather
invasive modification to support this feature?

I have vague memories of Dave Chinner mentioning work towards sharing
pages across address spaces in the interests of getting reflink copies
more competitive with overlayfs in terms of page cache utilization.

Dave did you ever end up going down this path?

Regards,
Vito Caputo

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-07-27 19:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-25  0:22 [QUESTION] Sharing a `struct page` across multiple `struct address_space` instances Vito Caputo
2020-07-25  3:11 ` Matthew Wilcox
2020-07-27 19:38   ` Vito Caputo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).