Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] reiserfs: only call unlock_new_inode() if I_NEW
@ 2020-06-28  7:00 Eric Biggers
  2020-07-27 16:52 ` Eric Biggers
  0 siblings, 1 reply; 4+ messages in thread
From: Eric Biggers @ 2020-06-28  7:00 UTC (permalink / raw)
  To: reiserfs-devel, linux-fsdevel; +Cc: linux-kernel, syzbot+187510916eb6a14598f7

From: Eric Biggers <ebiggers@google.com>

unlock_new_inode() is only meant to be called after a new inode has
already been inserted into the hash table.  But reiserfs_new_inode() can
call it even before it has inserted the inode, triggering the WARNING in
unlock_new_inode().  Fix this by only calling unlock_new_inode() if the
inode has the I_NEW flag set, indicating that it's in the table.

This addresses the syzbot report "WARNING in unlock_new_inode"
(https://syzkaller.appspot.com/bug?extid=187510916eb6a14598f7).

Reported-by: syzbot+187510916eb6a14598f7@syzkaller.appspotmail.com
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 fs/reiserfs/inode.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/reiserfs/inode.c b/fs/reiserfs/inode.c
index 1509775da040..e3af44c61524 100644
--- a/fs/reiserfs/inode.c
+++ b/fs/reiserfs/inode.c
@@ -2163,7 +2163,8 @@ int reiserfs_new_inode(struct reiserfs_transaction_handle *th,
 out_inserted_sd:
 	clear_nlink(inode);
 	th->t_trans_id = 0;	/* so the caller can't use this handle later */
-	unlock_new_inode(inode); /* OK to do even if we hadn't locked it */
+	if (inode->i_state & I_NEW)
+		unlock_new_inode(inode);
 	iput(inode);
 	return err;
 }
-- 
2.27.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] reiserfs: only call unlock_new_inode() if I_NEW
  2020-06-28  7:00 [PATCH] reiserfs: only call unlock_new_inode() if I_NEW Eric Biggers
@ 2020-07-27 16:52 ` Eric Biggers
  2020-09-16  4:01   ` Eric Biggers
  0 siblings, 1 reply; 4+ messages in thread
From: Eric Biggers @ 2020-07-27 16:52 UTC (permalink / raw)
  To: reiserfs-devel, linux-fsdevel; +Cc: linux-kernel, syzbot+187510916eb6a14598f7

On Sun, Jun 28, 2020 at 12:00:57AM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> unlock_new_inode() is only meant to be called after a new inode has
> already been inserted into the hash table.  But reiserfs_new_inode() can
> call it even before it has inserted the inode, triggering the WARNING in
> unlock_new_inode().  Fix this by only calling unlock_new_inode() if the
> inode has the I_NEW flag set, indicating that it's in the table.
> 
> This addresses the syzbot report "WARNING in unlock_new_inode"
> (https://syzkaller.appspot.com/bug?extid=187510916eb6a14598f7).
> 
> Reported-by: syzbot+187510916eb6a14598f7@syzkaller.appspotmail.com
> Signed-off-by: Eric Biggers <ebiggers@google.com>

Anyone interested in taking this patch?

- Eric

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] reiserfs: only call unlock_new_inode() if I_NEW
  2020-07-27 16:52 ` Eric Biggers
@ 2020-09-16  4:01   ` Eric Biggers
  2020-09-16 10:54     ` Jan Kara
  0 siblings, 1 reply; 4+ messages in thread
From: Eric Biggers @ 2020-09-16  4:01 UTC (permalink / raw)
  To: Jan Kara
  Cc: reiserfs-devel, linux-fsdevel, linux-kernel, syzbot+187510916eb6a14598f7

On Mon, Jul 27, 2020 at 09:52:15AM -0700, Eric Biggers wrote:
> On Sun, Jun 28, 2020 at 12:00:57AM -0700, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> > 
> > unlock_new_inode() is only meant to be called after a new inode has
> > already been inserted into the hash table.  But reiserfs_new_inode() can
> > call it even before it has inserted the inode, triggering the WARNING in
> > unlock_new_inode().  Fix this by only calling unlock_new_inode() if the
> > inode has the I_NEW flag set, indicating that it's in the table.
> > 
> > This addresses the syzbot report "WARNING in unlock_new_inode"
> > (https://syzkaller.appspot.com/bug?extid=187510916eb6a14598f7).
> > 
> > Reported-by: syzbot+187510916eb6a14598f7@syzkaller.appspotmail.com
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
> 
> Anyone interested in taking this patch?

Jan, you seem to be taking some reiserfs patches... Any interest in taking this
one?

- Eric

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] reiserfs: only call unlock_new_inode() if I_NEW
  2020-09-16  4:01   ` Eric Biggers
@ 2020-09-16 10:54     ` Jan Kara
  0 siblings, 0 replies; 4+ messages in thread
From: Jan Kara @ 2020-09-16 10:54 UTC (permalink / raw)
  To: Eric Biggers
  Cc: Jan Kara, reiserfs-devel, linux-fsdevel, linux-kernel,
	syzbot+187510916eb6a14598f7

On Tue 15-09-20 21:01:18, Eric Biggers wrote:
> On Mon, Jul 27, 2020 at 09:52:15AM -0700, Eric Biggers wrote:
> > On Sun, Jun 28, 2020 at 12:00:57AM -0700, Eric Biggers wrote:
> > > From: Eric Biggers <ebiggers@google.com>
> > > 
> > > unlock_new_inode() is only meant to be called after a new inode has
> > > already been inserted into the hash table.  But reiserfs_new_inode() can
> > > call it even before it has inserted the inode, triggering the WARNING in
> > > unlock_new_inode().  Fix this by only calling unlock_new_inode() if the
> > > inode has the I_NEW flag set, indicating that it's in the table.
> > > 
> > > This addresses the syzbot report "WARNING in unlock_new_inode"
> > > (https://syzkaller.appspot.com/bug?extid=187510916eb6a14598f7).
> > > 
> > > Reported-by: syzbot+187510916eb6a14598f7@syzkaller.appspotmail.com
> > > Signed-off-by: Eric Biggers <ebiggers@google.com>
> > 
> > Anyone interested in taking this patch?
> 
> Jan, you seem to be taking some reiserfs patches... Any interest in
> taking this one?

Sure, the patch looks good to me so I've added it to my tree. Thanks!

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-09-16 18:42 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-28  7:00 [PATCH] reiserfs: only call unlock_new_inode() if I_NEW Eric Biggers
2020-07-27 16:52 ` Eric Biggers
2020-09-16  4:01   ` Eric Biggers
2020-09-16 10:54     ` Jan Kara

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).