Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Dave Chinner <david@fromorbit.com>,
	"Darrick J. Wong" <darrick.wong@oracle.com>,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Brian Foster <bfoster@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iomap: Ensure iop->uptodate matches PageUptodate
Date: Tue, 28 Jul 2020 14:15:05 +0100	[thread overview]
Message-ID: <20200728131505.GQ23808@casper.infradead.org> (raw)
In-Reply-To: <20200728092301.GA32142@infradead.org>

On Tue, Jul 28, 2020 at 10:23:01AM +0100, Christoph Hellwig wrote:
> On Mon, Jul 27, 2020 at 09:53:35AM +1000, Dave Chinner wrote:
> > Yes, I understand the code accepts it can happen; what I dislike is
> > code that asserts subtle behaviour can happen, then doesn't describe
> > that exactly why/how that condition can occur. And then, because we
> > don't know exactly how something happens, we add work arounds to
> > hide issues we can't reason through fully. That's .... suboptimal.
> > 
> > Christoph might know off the top of his head how we get into this
> > state. Once we work it out, then we need to add comments...
> 
> Unfortunately I don't know offhand.  I'll need to spend some more
> quality time with this code first.

The code reads like you had several ideas for how the uptodate array
works, changing your mind as you went along, and it didn't quite get to
a coherent state before it was merged.  For example, there are parts
of the code which think that a clear bit in the uptodate array means
there's a hole in the file, eg

fs/iomap/seek.c:page_seek_hole_data() calls iomap_is_partially_uptodate()

but we set the uptodate bits when zeroing the parts of the page which
are covered by holes in iomap_readpage_actor()

> > > Way ahead of you
> > > http://git.infradead.org/users/willy/pagecache.git/commitdiff/5a1de6fc4f815797caa4a2f37c208c67afd7c20b
> > 
> > *nod*
> > 
> > I would suggest breaking that out as a separate cleanup patch and
> > not hide is in a patch that contains both THP modifications and bug
> > fixes. It stands alone as a valid cleanup.
> 
> I'm pretty sure I already suggested that when it first showed up.
> 
> That being said I have another somewhat related thing in this area
> that I really want to get done before THP support, and maybe I can
> offload it to willy:
> 
> Currently we always allocate the iomap_page structure for blocksize
> < PAGE_SIZE.  While this was easy to implement and a major improvement
> over the buffer heads it actually is quite silly, as we only actually
> need it if we either have sub-page uptodate state, or have extents
> boundaries in the page.  So what I'd like to do is to only actually
> allocate it in that case.  By doing the allocation lazy it should also
> help to never allocate one that is marked all uptodate from the start.

Hah, I want to do that too, and I was afraid I was going to have to
argue with you about it!

My thinking was to skip the allocation if the page lies entirely within
an iomap extent.  That will let us skip the allocation even for THPs
unless the file is fragmented.

I don't think it needs to get done before THP support, they're pretty
orthogonal.

      reply	other threads:[~2020-07-28 13:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-26  9:10 Matthew Wilcox (Oracle)
2020-07-26 15:15 ` Christoph Hellwig
2020-07-26 23:06 ` Dave Chinner
2020-07-26 23:20   ` Matthew Wilcox
2020-07-26 23:53     ` Dave Chinner
2020-07-28  9:23       ` Christoph Hellwig
2020-07-28 13:15         ` Matthew Wilcox [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200728131505.GQ23808@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=bfoster@redhat.com \
    --cc=darrick.wong@oracle.com \
    --cc=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --subject='Re: [PATCH] iomap: Ensure iop->uptodate matches PageUptodate' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).