From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2BD1C433E1 for ; Wed, 29 Jul 2020 15:33:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D1C8C2083B for ; Wed, 29 Jul 2020 15:33:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="QQT6atMv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726671AbgG2Pdz (ORCPT ); Wed, 29 Jul 2020 11:33:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726341AbgG2Pdz (ORCPT ); Wed, 29 Jul 2020 11:33:55 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16202C061794; Wed, 29 Jul 2020 08:33:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=LptujKmB75cZgkeinHbWmkaPdhq6d/VPDGBKjyx/cG0=; b=QQT6atMvYBKttOHS5earNdJ65+ ShnVfAiY4r06zZHni02DP1u45D0v/1crgTXoXCCXUPXsbHhWlood6tYOdxP9GWb7v9WB1HaePzAd0 BuWbyc4AJ3uQpemLrIhsVIkfDc0eOkN+yqX1EQwD0peX9MlfCwF9uBGYsJ9TRbJ4d1Ij1SQlINuDz FY4urNjx6Imqc8iSzU8gD/HmQd1bY5kIpVAGCOKPx55JUKG8WrAW+a9sJr9G2PuyqZ7R+92CBag2v PC4NkCsZ/UHXUHKMJOEeHYgo/umFEmN1vTkuhysdbn+yey5Dhe+yKpNxiFxzRocuHxsWG1eADZYN8 zkEffa3A==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1k0o5P-00061e-3T; Wed, 29 Jul 2020 15:33:43 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 6AAD2300238; Wed, 29 Jul 2020 17:33:41 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 26D8D203D2862; Wed, 29 Jul 2020 17:33:41 +0200 (CEST) Date: Wed, 29 Jul 2020 17:33:41 +0200 From: peterz@infradead.org To: Matthew Wilcox Cc: mingo@kernel.org, will@kernel.org, a.darwish@linutronix.de, tglx@linutronix.de, paulmck@kernel.org, bigeasy@linutronix.de, rostedt@goodmis.org, linux-kernel@vger.kernel.org, corbet@lwn.net, davem@davemloft.net, netdev@vger.kernel.org, linux-doc@vger.kernel.org, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 2/5] seqlock: Fold seqcount_LOCKNAME_t definition Message-ID: <20200729153341.GE2638@hirez.programming.kicks-ass.net> References: <20200729135249.567415950@infradead.org> <20200729140142.347671778@infradead.org> <20200729145507.GW23808@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200729145507.GW23808@casper.infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Jul 29, 2020 at 03:55:07PM +0100, Matthew Wilcox wrote: > On Wed, Jul 29, 2020 at 03:52:51PM +0200, Peter Zijlstra wrote: > > Manual repetition is boring and error prone. > > Yes, but generated functions are hard to grep for, and I'm pretty sure > that kernel-doc doesn't know how to expand macros into comments that it > can then extract documentation from. > > I've been thinking about how to cure this (mostly in the context > of page-flags.h). I don't particularly like the C preprocessor, but > m4 is worse and defining our own preprocessing language seems like a > terrible idea. > > So I was thinking about moving the current contents of page-flags.h > to include/src/page-flags.h, making linux/page-flags.h depend on > src/page-flags.h and run '$(CPP) -C' to generate it. I've been a little > busy recently and haven't had time to do more than muse about this, but > I think it might make sense for some of our more heavily macro-templated > header files. Use ctags and add to scripts/tags.sh.