Linux-Fsdevel Archive on
help / color / mirror / Atom feed
To: Christoph Hellwig <>
Cc: Jacob Wen <>,,
Subject: Re: [PATCH] block: insert a general SMP memory barrier before wake_up_bit()
Date: Thu, 13 Aug 2020 13:40:50 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, Aug 13, 2020 at 08:31:15AM +0100, Christoph Hellwig wrote:
> On Thu, Aug 13, 2020 at 10:44:38AM +0800, Jacob Wen wrote:
> > wake_up_bit() uses waitqueue_active() that needs the explicit smp_mb().
> Sounds like the barrier should go into wake_up_bit then..

Oh, thanks for reminding me..

I'll try and get back to that.

  parent reply	other threads:[~2020-08-13 11:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-13  2:44 Jacob Wen
2020-08-13  3:00 ` Chaitanya Kulkarni
2020-08-13  7:31 ` Christoph Hellwig
2020-08-13  7:46   ` Jacob Wen
2020-08-13 11:40   ` peterz [this message]
2020-08-13 12:00     ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [PATCH] block: insert a general SMP memory barrier before wake_up_bit()' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).