Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: Yu Kuai <yukuai3@huawei.com>,
	hch@infradead.org, darrick.wong@oracle.com, david@fromorbit.com,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, yi.zhang@huawei.com
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Subject: [PATCH 2/3] iomap: Use bitmap ops to set uptodate bits
Date: Fri, 21 Aug 2020 13:46:05 +0100	[thread overview]
Message-ID: <20200821124606.10165-2-willy@infradead.org> (raw)
In-Reply-To: <20200821124606.10165-1-willy@infradead.org>

Now that the bitmap is protected by a spinlock, we can use the
more efficient bitmap ops instead of individual test/set bit ops.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
 fs/iomap/buffered-io.c | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
index 639d54a4177e..dbf9572dabe9 100644
--- a/fs/iomap/buffered-io.c
+++ b/fs/iomap/buffered-io.c
@@ -134,19 +134,11 @@ iomap_iop_set_range_uptodate(struct page *page, unsigned off, unsigned len)
 	struct inode *inode = page->mapping->host;
 	unsigned first = off >> inode->i_blkbits;
 	unsigned last = (off + len - 1) >> inode->i_blkbits;
-	bool uptodate = true;
 	unsigned long flags;
-	unsigned int i;
 
 	spin_lock_irqsave(&iop->uptodate_lock, flags);
-	for (i = 0; i < i_blocks_per_page(inode, page); i++) {
-		if (i >= first && i <= last)
-			set_bit(i, iop->uptodate);
-		else if (!test_bit(i, iop->uptodate))
-			uptodate = false;
-	}
-
-	if (uptodate)
+	bitmap_set(iop->uptodate, first, last - first + 1);
+	if (bitmap_full(iop->uptodate, i_blocks_per_page(inode, page)))
 		SetPageUptodate(page);
 	spin_unlock_irqrestore(&iop->uptodate_lock, flags);
 }
-- 
2.28.0


  reply	other threads:[~2020-08-21 12:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-21 12:33 [RFC PATCH V4] iomap: add support to track dirty state of sub pages Yu Kuai
2020-08-21 12:44 ` Matthew Wilcox
2020-08-21 12:46   ` [PATCH 1/3] iomap: Use kzalloc to allocate iomap_page Matthew Wilcox (Oracle)
2020-08-21 12:46     ` Matthew Wilcox (Oracle) [this message]
2020-08-22  5:59       ` [PATCH 2/3] iomap: Use bitmap ops to set uptodate bits Christoph Hellwig
2020-08-21 12:46     ` [PATCH 3/3] iomap: Support arbitrarily many blocks per page Matthew Wilcox (Oracle)
2020-08-21 12:48       ` Matthew Wilcox
2020-08-22  6:01       ` Christoph Hellwig
2020-08-22  5:57     ` [PATCH 1/3] iomap: Use kzalloc to allocate iomap_page Christoph Hellwig
2020-09-11  8:27   ` [RFC PATCH V4] iomap: add support to track dirty state of sub pages yukuai (C)
2020-09-11  8:35     ` yukuai (C)
2020-09-11 12:05     ` Matthew Wilcox
2020-09-25  2:30       ` yukuai (C)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200821124606.10165-2-willy@infradead.org \
    --to=willy@infradead.org \
    --cc=darrick.wong@oracle.com \
    --cc=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai3@huawei.com \
    --subject='Re: [PATCH 2/3] iomap: Use bitmap ops to set uptodate bits' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).