Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Xianting Tian <xianting_tian@126.com>
Cc: bcrl@kvack.org, viro@zeniv.linux.org.uk, linux-aio@kvack.org,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] aio: use wait_for_completion_io() when waiting for completion of io
Date: Wed, 26 Aug 2020 15:23:30 +0200	[thread overview]
Message-ID: <20200826132330.GD15126@quack2.suse.cz> (raw)
In-Reply-To: <1596634551-27526-1-git-send-email-xianting_tian@126.com>

On Wed 05-08-20 09:35:51, Xianting Tian wrote:
> When waiting for the completion of io, we need account iowait time. As
> wait_for_completion() calls schedule_timeout(), which doesn't account
> iowait time. While wait_for_completion_io() calls io_schedule_timeout(),
> which will account iowait time.
> 
> So using wait_for_completion_io() instead of wait_for_completion()
> when waiting for completion of io before exit_aio and io_destroy.
> 
> Signed-off-by: Xianting Tian <xianting_tian@126.com>

Thanks for the patch! It looks good to me but IMO this is just scratching
the surface.  E.g. for AIO we are mostly going to wait in read_events() by
wait_event_interruptible_hrtimeout() and *that* doesn't account as IO wait
either? Which is IMO far bigger misaccounting... The two case you fix seem
to be just rare cornercases so what they do isn't a big deal either way.

So I agree it may be worth it to properly account waiting for AIO but if
you want to do that, then please handle mainly the common cases in AIO
code.

								Honza

> ---
>  fs/aio.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/aio.c b/fs/aio.c
> index 91e7cc4..498b8a0 100644
> --- a/fs/aio.c
> +++ b/fs/aio.c
> @@ -892,7 +892,7 @@ void exit_aio(struct mm_struct *mm)
>  
>  	if (!atomic_sub_and_test(skipped, &wait.count)) {
>  		/* Wait until all IO for the context are done. */
> -		wait_for_completion(&wait.comp);
> +		wait_for_completion_io(&wait.comp);
>  	}
>  
>  	RCU_INIT_POINTER(mm->ioctx_table, NULL);
> @@ -1400,7 +1400,7 @@ static long read_events(struct kioctx *ctx, long min_nr, long nr,
>  		 * is destroyed.
>  		 */
>  		if (!ret)
> -			wait_for_completion(&wait.comp);
> +			wait_for_completion_io(&wait.comp);
>  
>  		return ret;
>  	}
> -- 
> 1.8.3.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

  reply	other threads:[~2020-08-26 13:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-05 13:35 Xianting Tian
2020-08-26 13:23 ` Jan Kara [this message]
     [not found]   ` <26ae9330.63f4.1742b70dd88.Coremail.xianting_tian@126.com>
2020-08-27  7:55     ` Jan Kara
     [not found]       ` <5ef5b380.877b.1742f087437.Coremail.xianting_tian@126.com>
2020-08-27  8:46         ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200826132330.GD15126@quack2.suse.cz \
    --to=jack@suse.cz \
    --cc=bcrl@kvack.org \
    --cc=linux-aio@kvack.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=xianting_tian@126.com \
    --subject='Re: [PATCH] aio: use wait_for_completion_io() when waiting for completion of io' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).