Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: david@fromorbit.com, hch@infradead.org, darrick.wong@oracle.com,
	mhocko@kernel.org, akpm@linux-foundation.org,
	linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [PATCH v7 2/2] xfs: avoid transaction reservation recursion
Date: Thu, 27 Aug 2020 02:58:53 +0100	[thread overview]
Message-ID: <20200827015853.GA14765@casper.infradead.org> (raw)
In-Reply-To: <20200827013444.24270-3-laoar.shao@gmail.com>

On Thu, Aug 27, 2020 at 09:34:44AM +0800, Yafang Shao wrote:
> @@ -1500,9 +1500,9 @@ iomap_do_writepage(struct page *page, struct writeback_control *wbc, void *data)
>  
>  	/*
>  	 * Given that we do not allow direct reclaim to call us, we should
> -	 * never be called in a recursive filesystem reclaim context.
> +	 * never be called while in a filesystem transaction.
>  	 */
> -	if (WARN_ON_ONCE(current->flags & PF_MEMALLOC_NOFS))
> +	if (WARN_ON_ONCE(wbc->fstrans_recursion))
>  		goto redirty;

Erm, Dave said:

> I think we should just remove
> the check completely from iomap_writepage() and move it up into
> xfs_vm_writepage() and xfs_vm_writepages().

ie everywhere you set this new bit, just check current->journal_info.

  reply	other threads:[~2020-08-27  1:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-27  1:34 [PATCH v7 0/2] avoid xfs " Yafang Shao
2020-08-27  1:34 ` [PATCH v7 1/2] mm: Add become_kswapd and restore_kswapd Yafang Shao
2020-08-27  1:34 ` [PATCH v7 2/2] xfs: avoid transaction reservation recursion Yafang Shao
2020-08-27  1:58   ` Matthew Wilcox [this message]
2020-08-27  2:13     ` Yafang Shao
2020-08-27  2:42       ` Dave Chinner
2020-08-27  2:59         ` Yafang Shao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200827015853.GA14765@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=darrick.wong@oracle.com \
    --cc=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=laoar.shao@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=mhocko@kernel.org \
    --subject='Re: [PATCH v7 2/2] xfs: avoid transaction reservation recursion' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).