From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E085C2BBDB for ; Thu, 3 Sep 2020 19:22:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 30C6B214F1 for ; Thu, 3 Sep 2020 19:22:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599160943; bh=qrU9WP85gio2U/xOxsjI6OQmaemPSNLwvExZVcQaiJI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=w6YszAV10BN0CAvBZDbtgWaLOBJjD+lfUrLKDQQ1qqGsqtye3GPbt07pjElzUk3Te 5puMcL8Bh1txm3fHTVBkRrzK3aMDJtJMiqzcKzZZtb3aRP/DaYrDujGbLgmXwlJqQq EvlzrSjDUzS/EpT5o7FpSasldyy6ySO7JA/LFrzU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729279AbgICTWW (ORCPT ); Thu, 3 Sep 2020 15:22:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:38990 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729223AbgICTWU (ORCPT ); Thu, 3 Sep 2020 15:22:20 -0400 Received: from X1 (nat-ab2241.sltdut.senawave.net [162.218.216.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 15FE4208FE; Thu, 3 Sep 2020 19:22:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599160940; bh=qrU9WP85gio2U/xOxsjI6OQmaemPSNLwvExZVcQaiJI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IrPwGOqTv/KWNBrt1u4S7EwYUUGRjlpElggScKVY+7W4Ixse0AjqAOzDwaanViz3l h0Wh9hdgoPIDK9ZlLTdqUMzrwfafpurypMlMfvJrYkdIfuynzS1Klva+0zkKp12SRc FuObmMfsMgQHesWMfhIyVMomBTTbEaa4bKwUWGpw= Date: Thu, 3 Sep 2020 12:22:18 -0700 From: Andrew Morton To: "Matthew Wilcox (Oracle)" Cc: David Howells , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Eric Biggers Subject: Re: [PATCH 3/9] mm/readahead: Make page_cache_ra_unbounded take a readahead_control Message-Id: <20200903122218.42bd70d930cba998e3faf32c@linux-foundation.org> In-Reply-To: <20200903140844.14194-4-willy@infradead.org> References: <20200903140844.14194-1-willy@infradead.org> <20200903140844.14194-4-willy@infradead.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, 3 Sep 2020 15:08:38 +0100 "Matthew Wilcox (Oracle)" wrote: > Define it in the callers instead of in page_cache_ra_unbounded(). > The changelogs for patches 2-9 are explaining what the patches do, but not why they do it, Presumably there's some grand scheme in mind, but it isn't being revealed to the reader!