Linux-Fsdevel Archive on lore.kernel.org help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de> To: Jens Axboe <axboe@kernel.dk> Cc: Denis Efremov <efremov@linux.com>, Tim Waugh <tim@cyberelk.net>, Michal Simek <michal.simek@xilinx.com>, Borislav Petkov <bp@alien8.de>, "David S. Miller" <davem@davemloft.net>, Song Liu <song@kernel.org>, "Martin K. Petersen" <martin.petersen@oracle.com>, Finn Thain <fthain@telegraphics.com.au>, Michael Schmitz <schmitzmic@gmail.com>, linux-m68k@lists.linux-m68k.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, linux-raid@vger.kernel.org, linux-scsi@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [PATCH 04/19] floppy: use bdev_check_media_change Date: Tue, 8 Sep 2020 16:53:32 +0200 [thread overview] Message-ID: <20200908145347.2992670-5-hch@lst.de> (raw) In-Reply-To: <20200908145347.2992670-1-hch@lst.de> Switch to use bdev_check_media_change instead of check_disk_change and call floppy_revalidate manually. Given that floppy_revalidate only deals with media change events, the extra call into ->revalidate_disk from bdev_disk_changed is not required either, so stop wiring up the method. Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/block/floppy.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c index a563b023458a8b..7df79ae6b0a1e1 100644 --- a/drivers/block/floppy.c +++ b/drivers/block/floppy.c @@ -561,6 +561,7 @@ static void floppy_release_irq_and_dma(void); * output_byte is automatically disabled when reset is set. */ static void reset_fdc(void); +static int floppy_revalidate(struct gendisk *disk); /* * These are global variables, as that's the easiest way to give @@ -3275,7 +3276,8 @@ static int invalidate_drive(struct block_device *bdev) /* invalidate the buffer track to force a reread */ set_bit((long)bdev->bd_disk->private_data, &fake_change); process_fd_request(); - check_disk_change(bdev); + if (bdev_check_media_change(bdev)) + floppy_revalidate(bdev->bd_disk); return 0; } @@ -4123,7 +4125,8 @@ static int floppy_open(struct block_device *bdev, fmode_t mode) drive_state[drive].last_checked = 0; clear_bit(FD_OPEN_SHOULD_FAIL_BIT, &drive_state[drive].flags); - check_disk_change(bdev); + if (bdev_check_media_change(bdev)) + floppy_revalidate(bdev->bd_disk); if (test_bit(FD_DISK_CHANGED_BIT, &drive_state[drive].flags)) goto out; if (test_bit(FD_OPEN_SHOULD_FAIL_BIT, &drive_state[drive].flags)) @@ -4291,7 +4294,6 @@ static const struct block_device_operations floppy_fops = { .ioctl = fd_ioctl, .getgeo = fd_getgeo, .check_events = floppy_check_events, - .revalidate_disk = floppy_revalidate, #ifdef CONFIG_COMPAT .compat_ioctl = fd_compat_ioctl, #endif -- 2.28.0
next prev parent reply other threads:[~2020-09-08 19:44 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-08 14:53 rework check_disk_change() v2 Christoph Hellwig 2020-09-08 14:53 ` [PATCH 01/19] block: add a bdev_check_media_change helper Christoph Hellwig 2020-09-09 6:59 ` Hannes Reinecke 2020-09-08 14:53 ` [PATCH 02/19] amiflop: use bdev_check_media_change Christoph Hellwig 2020-09-09 6:59 ` Hannes Reinecke 2020-09-08 14:53 ` [PATCH 03/19] ataflop: " Christoph Hellwig 2020-09-09 7:00 ` Hannes Reinecke 2020-09-08 14:53 ` Christoph Hellwig [this message] 2020-09-09 6:52 ` [PATCH 04/19] floppy: " Johannes Thumshirn 2020-09-09 7:00 ` Hannes Reinecke 2020-09-08 14:53 ` [PATCH 05/19] swim: " Christoph Hellwig 2020-09-09 7:01 ` Hannes Reinecke 2020-09-08 14:53 ` [PATCH 06/19] swim: simplify media change handling Christoph Hellwig 2020-09-09 7:09 ` Hannes Reinecke 2020-09-08 14:53 ` [PATCH 07/19] swim3: use bdev_check_media_changed Christoph Hellwig 2020-09-09 7:10 ` Hannes Reinecke 2020-09-09 7:50 ` Sergei Shtylyov 2020-09-08 14:53 ` [PATCH 08/19] xsysace: use bdev_check_media_change Christoph Hellwig 2020-09-09 7:10 ` Hannes Reinecke 2020-09-08 14:53 ` [PATCH 09/19] xsysace: simplify media change handling Christoph Hellwig 2020-09-09 7:10 ` Hannes Reinecke 2020-09-08 14:53 ` [PATCH 10/19] paride/pcd: use bdev_check_media_change Christoph Hellwig 2020-09-09 7:26 ` Hannes Reinecke 2020-09-08 14:53 ` [PATCH 11/19] gdrom: " Christoph Hellwig 2020-09-09 7:27 ` Hannes Reinecke 2020-09-08 14:53 ` [PATCH 12/19] ide-cd: use bdev_check_media_changed Christoph Hellwig 2020-09-09 7:27 ` Hannes Reinecke 2020-09-08 14:53 ` [PATCH 13/19] ide-cd: remove idecd_revalidate_disk Christoph Hellwig 2020-09-09 7:28 ` Hannes Reinecke 2020-09-08 14:53 ` [PATCH 14/19] ide-gd: stop using the disk events mechanism Christoph Hellwig 2020-09-09 7:32 ` Hannes Reinecke 2020-09-08 14:53 ` [PATCH 15/19] md: use bdev_check_media_change Christoph Hellwig 2020-09-09 0:49 ` Song Liu 2020-09-09 7:34 ` Hannes Reinecke 2020-09-08 14:53 ` [PATCH 16/19] sd: " Christoph Hellwig 2020-09-09 7:36 ` Hannes Reinecke 2020-09-09 7:52 ` Sergei Shtylyov 2020-09-08 14:53 ` [PATCH 17/19] sr: " Christoph Hellwig 2020-09-09 7:37 ` Hannes Reinecke 2020-09-08 14:53 ` [PATCH 18/19] sr: simplify sr_block_revalidate_disk Christoph Hellwig 2020-09-09 7:38 ` Hannes Reinecke 2020-09-08 14:53 ` [PATCH 19/19] block: remove check_disk_change Christoph Hellwig 2020-09-09 7:39 ` Hannes Reinecke 2020-09-10 15:54 ` rework check_disk_change() v2 Jens Axboe -- strict thread matches above, loose matches on Subject: below -- 2020-09-02 14:11 rework check_disk_change() Christoph Hellwig 2020-09-02 14:12 ` [PATCH 04/19] floppy: use bdev_check_media_change Christoph Hellwig 2020-09-02 15:24 ` Johannes Thumshirn
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200908145347.2992670-5-hch@lst.de \ --to=hch@lst.de \ --cc=axboe@kernel.dk \ --cc=bp@alien8.de \ --cc=davem@davemloft.net \ --cc=efremov@linux.com \ --cc=fthain@telegraphics.com.au \ --cc=linux-block@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-ide@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-m68k@lists.linux-m68k.org \ --cc=linux-raid@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=michal.simek@xilinx.com \ --cc=schmitzmic@gmail.com \ --cc=song@kernel.org \ --cc=tim@cyberelk.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).