From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC56CC433E2 for ; Wed, 16 Sep 2020 23:28:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8205422208 for ; Wed, 16 Sep 2020 23:28:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726476AbgIPX2U (ORCPT ); Wed, 16 Sep 2020 19:28:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726084AbgIPX2T (ORCPT ); Wed, 16 Sep 2020 19:28:19 -0400 Received: from ZenIV.linux.org.uk (zeniv.linux.org.uk [IPv6:2002:c35c:fd02::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E701CC06174A for ; Wed, 16 Sep 2020 16:28:18 -0700 (PDT) Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIgqO-0003ce-NC; Wed, 16 Sep 2020 23:28:08 +0000 Date: Thu, 17 Sep 2020 00:28:08 +0100 From: Al Viro To: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= Cc: Jeff Layton , "J. Bruce Fields" , Matthew Wilcox , linux-fsdevel@vger.kernel.org, Jens Axboe , Andrew Morton Subject: Re: [PATCH v3] fs: Remove duplicated flag O_NDELAY occurring twice in VALID_OPEN_FLAGS Message-ID: <20200916232808.GN3421308@ZenIV.linux.org.uk> References: <20200906223949.62771-1-kw@linux.com> <20200916193500.GA25498@rocinante> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200916193500.GA25498@rocinante> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Sep 16, 2020 at 09:35:00PM +0200, Krzysztof WilczyƄski wrote: > [+CC Andrew] > > Hello, > > Thank you Matthew and Jens for review! > > Andrew, do you think this trivial patch is something that could be > included? > > I run Coccinelle on a regular basis as part of my build and test process > when working and this warning shows up there all the time. I thought, > it would be nice to put it to rest. In #work.misc, will be in -next shortly.