Linux-Fsdevel Archive on lore.kernel.org help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org> To: "Matthew Wilcox (Oracle)" <willy@infradead.org> Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH 16/13] iomap: Make readpage synchronous Date: Sat, 19 Sep 2020 07:39:08 +0100 [thread overview] Message-ID: <20200919063908.GH13501@infradead.org> (raw) In-Reply-To: <20200917225647.26481-3-willy@infradead.org> I think just adding the completion and status to struct iomap_readpage_ctx would be a lot easier to follow, at the cost of bloating the structure a bit for the readahead case. If we are realy concerned about that, the completion could be directly on the iomap_readpage stack and we'd pass a pointer.
next prev parent reply other threads:[~2020-09-19 6:39 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-17 15:10 [PATCH 00/13] Allow readpage to return a locked page Matthew Wilcox (Oracle) 2020-09-17 15:10 ` [PATCH 01/13] mm: Add AOP_UPDATED_PAGE return value Matthew Wilcox (Oracle) 2020-09-17 22:03 ` Matthew Wilcox 2020-09-17 15:10 ` [PATCH 02/13] 9p: Tell the VFS that readpage was synchronous Matthew Wilcox (Oracle) 2020-09-18 5:59 ` [V9fs-developer] " Dominique Martinet 2020-09-18 11:19 ` Matthew Wilcox 2020-09-18 12:30 ` Dominique Martinet 2020-09-17 15:10 ` [PATCH 03/13] afs: " Matthew Wilcox (Oracle) 2020-09-17 15:10 ` [PATCH 04/13] ceph: " Matthew Wilcox (Oracle) 2020-09-17 16:49 ` Jeff Layton 2020-09-17 15:10 ` [PATCH 05/13] cifs: " Matthew Wilcox (Oracle) 2020-09-17 15:10 ` [PATCH 06/13] cramfs: " Matthew Wilcox (Oracle) 2020-09-17 15:10 ` [PATCH 07/13] ecryptfs: " Matthew Wilcox (Oracle) 2020-09-17 15:10 ` [PATCH 08/13] fuse: " Matthew Wilcox (Oracle) 2020-09-17 15:10 ` [PATCH 09/13] hostfs: " Matthew Wilcox (Oracle) 2020-09-17 15:10 ` [PATCH 10/13] jffs2: " Matthew Wilcox (Oracle) 2020-09-17 15:10 ` [PATCH 11/13] ubifs: " Matthew Wilcox (Oracle) 2020-09-17 20:46 ` Richard Weinberger 2020-09-17 15:10 ` [PATCH 12/13] udf: " Matthew Wilcox (Oracle) 2020-09-24 9:00 ` Jan Kara 2020-09-17 15:10 ` [PATCH 13/13] vboxsf: " Matthew Wilcox (Oracle) 2020-09-17 22:56 ` [PATCH 14/13] iomap: Inline iomap_iop_set_range_uptodate into its one caller Matthew Wilcox (Oracle) 2020-09-17 22:56 ` [PATCH 15/13] iomap: Inline iomap_read_finish " Matthew Wilcox (Oracle) 2020-09-19 6:31 ` Christoph Hellwig 2020-09-17 22:56 ` [PATCH 16/13] iomap: Make readpage synchronous Matthew Wilcox (Oracle) 2020-09-19 6:39 ` Christoph Hellwig [this message] 2020-09-19 6:43 ` Christoph Hellwig 2020-09-19 17:03 ` Matthew Wilcox 2020-09-19 17:10 ` Matthew Wilcox 2020-09-19 6:31 ` [PATCH 14/13] iomap: Inline iomap_iop_set_range_uptodate into its one caller Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200919063908.GH13501@infradead.org \ --to=hch@infradead.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-xfs@vger.kernel.org \ --cc=willy@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).