Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: David Laight <David.Laight@aculab.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"io-uring@vger.kernel.org" <io-uring@vger.kernel.org>,
	Jens Axboe <axboe@kernel.dk>,
	"David S. Miller" <davem@davemloft.net>,
	Al Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 1/9 next] mm:process_vm_access Call import_iovec() instead of rw_copy_check_uvector()
Date: Mon, 21 Sep 2020 15:09:35 +0100	[thread overview]
Message-ID: <20200921140935.GA24515@infradead.org> (raw)
In-Reply-To: <e47d19f9c946423db88de10b4753ecfb@AcuMS.aculab.com>

On Tue, Sep 15, 2020 at 02:55:08PM +0000, David Laight wrote:
> 
> This is the only direct call of rw_copy_check_uvector().
> Removing it lets rw_copy_check_uvector() be inlined into
> import_iovec() and the horrid calling conventions fixed.

This looks sensible, but as-is will create a warning when actually
this code.

This is the variant I picked up as a prep patch for the compat
iovec handling, which passes the relevant LTP tests:

http://git.infradead.org/users/hch/misc.git/commitdiff/9e3cf5d0f13572310354bf6c62e1feb9fb232266

      reply	other threads:[~2020-09-21 14:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-15 14:55 David Laight
2020-09-21 14:09 ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200921140935.GA24515@infradead.org \
    --to=hch@infradead.org \
    --cc=David.Laight@aculab.com \
    --cc=axboe@kernel.dk \
    --cc=davem@davemloft.net \
    --cc=io-uring@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --subject='Re: [PATCH 1/9 next] mm:process_vm_access Call import_iovec() instead of rw_copy_check_uvector()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).