Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Al Viro <viro@zeniv.linux.org.uk>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Christoph Hellwig <hch@lst.de>,
Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 5/5] fs: remove do_mounts
Date: Sun, 11 Oct 2020 19:01:02 +0100 [thread overview]
Message-ID: <20201011180102.GB3576660@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20201011141749.GA126978@roeck-us.net>
On Sun, Oct 11, 2020 at 07:17:49AM -0700, Guenter Roeck wrote:
> Someone didn't bother test building this patch.
>
> arch/alpha/kernel/osf_sys.c: In function '__do_sys_osf_mount':
> arch/alpha/kernel/osf_sys.c:437:14: error: 'path' redeclared as different kind of symbol
Quite. Matter of fact, there's another problem (path_mount()
that needs to be moved from fs/internal.h for that) and IMO this
is simply not worth bothering with. I don't see any benefits
in the last commit in there; the next-to-last one has some
point, and it's not hard to fix, but since it clearly got
no testing whatsoever... Christoph, if you want it back,
resend it later, *after* having tested it. qemu-system-alpha
works well enough to boot the last released debian/alpha.
For now I'm dropping the last two commits from that branch.
prev parent reply other threads:[~2020-10-11 18:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 8:22 remove compat_sys_mount Christoph Hellwig
2020-09-17 8:22 ` [PATCH 1/5] nfs: simplify nfs4_parse_monolithic Christoph Hellwig
2020-09-17 8:22 ` [PATCH 2/5] fs,nfs: lift compat nfs4 mount data handling into the nfs code Christoph Hellwig
2020-09-17 17:16 ` Al Viro
2020-09-17 17:18 ` Christoph Hellwig
2020-09-21 6:48 ` Christoph Hellwig
2020-09-21 16:05 ` Anna Schumaker
2020-09-21 18:11 ` Christoph Hellwig
2020-09-23 3:45 ` Al Viro
2020-09-17 8:22 ` [PATCH 3/5] fs: remove compat_sys_mount Christoph Hellwig
2020-09-17 8:22 ` [PATCH 4/5] alpha: simplify osf_mount Christoph Hellwig
2020-10-11 14:22 ` Guenter Roeck
2020-09-17 8:22 ` [PATCH 5/5] fs: remove do_mounts Christoph Hellwig
2020-10-11 14:17 ` Guenter Roeck
2020-10-11 18:01 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201011180102.GB3576660@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=anna.schumaker@netapp.com \
--cc=hch@lst.de \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mattst88@gmail.com \
--cc=rth@twiddle.net \
--cc=trond.myklebust@hammerspace.com \
--subject='Re: [PATCH 5/5] fs: remove do_mounts' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).