Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Minwoo Im <minwoo.im.dev@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
Subject: Re: [RFC PATCH V3 1/1] block: reject I/O for same fd if block size changed
Date: Tue, 5 Jan 2021 19:12:02 +0900	[thread overview]
Message-ID: <20210105101202.GA9970@localhost.localdomain> (raw)
In-Reply-To: <20210105075009.GA30039@lst.de>

Hello,

On 21-01-05 08:50:09, Christoph Hellwig wrote:
> On Tue, Jan 05, 2021 at 10:04:56AM +0900, Minwoo Im wrote:
> > It was a point that I really would like to ask by RFC whether we can
> > have backpointer to the gendisk from the request_queue.  And I'd like to
> > have it to simplify this routine and for future usages also.
> 
> I think it is the right thing to do, at least mid-term, although I
> don't want to enforce the burden on you right now.
> 
> > I will restrict this one by checking GENHD_FL_UP flag from the gendisk
> > for the next patch.
> > 
> > > 
> > > Alternatively we could make this request_queue QUEUE* flag for now.
> > 
> > As this patch rejects I/O from the block layer partition code, can we
> > have this flag in gendisk rather than request_queue ?
> 
> For now we can as the request_queue is required.  I have some plans to
> clean up this area, but just using a request_queue flag for now is
> probably the simplest, even if it means more work for me later.

Please let me prepare the next quick fix for this issue with request_queue
flag.

Thanks!

      reply	other threads:[~2021-01-05 10:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-04 13:06 [RFC PATCH V3 0/1] block: fix I/O errors in BLKRRPART Minwoo Im
2021-01-04 13:06 ` [RFC PATCH V3 1/1] block: reject I/O for same fd if block size changed Minwoo Im
2021-01-04 17:11   ` Christoph Hellwig
2021-01-04 17:11     ` Christoph Hellwig
2021-01-05  1:04       ` Minwoo Im
2021-01-05  7:50         ` Christoph Hellwig
2021-01-05 10:12           ` Minwoo Im [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210105101202.GA9970@localhost.localdomain \
    --to=minwoo.im.dev@gmail.com \
    --cc=Chaitanya.Kulkarni@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --subject='Re: [RFC PATCH V3 1/1] block: reject I/O for same fd if block size changed' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).