Linux-Fsdevel Archive on
help / color / mirror / Atom feed
From: Jens Axboe <>
To: Jan Kara <>,
	Christoph Hellwig <>, yebin <>,
	Andreas Dilger <>
Subject: Re: [PATCH 0/2 v2] bdev: Avoid discarding buffers under a filesystem
Date: Mon, 7 Sep 2020 10:24:01 -0600	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 9/7/20 4:35 AM, Jan Kara wrote:
> Hello!
> On Fri 04-09-20 10:58:50, Jan Kara wrote:
>> this patch set fixes problems when buffer heads are discarded under a
>> live filesystem (which can lead to all sorts of issues like crashes in case
>> of ext4). Patch 1 drops some stale buffer invalidation code, patch 2
>> temporarily gets exclusive access to the block device for the duration of
>> buffer cache handling to avoid interfering with other exclusive bdev user.
>> The patch fixes the problems for me and pass xfstests for ext4.
>> Changes since v1:
>> * Check for exclusive access to the bdev instead of for the presence of
>>   superblock
> Jens, now that Christoph has reviewed the patches (thanks Christoph!), can
> you pick up the patches to your tree please? Thanks!

Yep, I applied them for 5.10. Thanks!

Jens Axboe

      reply	other threads:[~2020-09-07 16:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-04  8:58 Jan Kara
2020-09-04  8:58 ` [PATCH 1/2] fs: Don't invalidate page buffers in block_write_full_page() Jan Kara
2020-09-07  7:12   ` Christoph Hellwig
2020-09-04  8:58 ` [PATCH 2/2] block: Do not discard buffers under a mounted filesystem Jan Kara
2020-09-07  7:12   ` Christoph Hellwig
2020-09-07 10:35 ` [PATCH 0/2 v2] bdev: Avoid discarding buffers under a filesystem Jan Kara
2020-09-07 16:24   ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH 0/2 v2] bdev: Avoid discarding buffers under a filesystem' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).