Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Sungjong Seo" <sj1557.seo@samsung.com>
To: "'Tetsuhiro Kohada'" <kohada.t2@gmail.com>
Cc: <kohada.tetsuhiro@dc.mitsubishielectric.co.jp>,
	<mori.takahiro@ab.mitsubishielectric.co.jp>,
	<motai.hirotaka@aj.mitsubishielectric.co.jp>,
	"'Namjae Jeon'" <namjae.jeon@samsung.com>,
	<linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] exfat: remove 'rwoffset' in exfat_inode_info
Date: Fri, 25 Sep 2020 09:56:43 +0900	[thread overview]
Message-ID: <711c01d692d6$bc389610$34a9c230$@samsung.com> (raw)
In-Reply-To: <0f9d3d3e-075f-511d-12e5-21346bca081e@gmail.com>

> On 2020/09/12 14:01, Sungjong Seo wrote:
> >> Remove 'rwoffset' in exfat_inode_info and replace it with the
> >> parameter(cpos) of exfat_readdir.
> >> Since rwoffset of  is referenced only by exfat_readdir, it is not
> >> necessary a exfat_inode_info's member.
> >>
> >> Signed-off-by: Tetsuhiro Kohada <kohada.t2@gmail.com>
> >> ---
> >>   fs/exfat/dir.c      | 16 ++++++----------
> >>   fs/exfat/exfat_fs.h |  2 --
> >>   fs/exfat/file.c     |  2 --
> >>   fs/exfat/inode.c    |  3 ---
> >>   fs/exfat/super.c    |  1 -
> >>   5 files changed, 6 insertions(+), 18 deletions(-)
> >>
> >> diff --git a/fs/exfat/dir.c b/fs/exfat/dir.c index
> >> a9b13ae3f325..fa5bb72aa295 100644
> >> --- a/fs/exfat/dir.c
> >> +++ b/fs/exfat/dir.c
> > [snip]
> >> sector @@ -262,13 +260,11 @@ static int exfat_iterate(struct file
> >> *filp, struct dir_context *ctx)
> >>   		goto end_of_dir;
> >>   	}
> >>
> >> -	cpos = EXFAT_DEN_TO_B(ei->rwoffset);
> >> -
> >>   	if (!nb->lfn[0])
> >>   		goto end_of_dir;
> >>
> >>   	i_pos = ((loff_t)ei->start_clu << 32) |
> >> -		((ei->rwoffset - 1) & 0xffffffff);
> >> +		(EXFAT_B_TO_DEN(cpos-1) & 0xffffffff);
> >
> > Need to fix the above line to be:
> > (EXFAT_B_TO_DEN(cpos)-1)) & 0xffffffff);
> 
> 
> Here, we simply converted so that the calculation results would be the
> same.
> But after reading it carefully again, I noticed.
>   - Why use the previous entry?
>   - Why does cpos point to stream dir-entry in entry-set?
> 
> For the former, there is no need to "++dentry" in exfat_readdir().
> For the latter, I think cpos should point to the next to current entry-set.
> 
> I'll make V2 considering these.
> How do you think?

The latter looks better.
> 
> BR
> ---
> Tetsuhiro Kohada <kohada.t2@gmail.com>



      reply	other threads:[~2020-09-25  1:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200909075713epcas1p44c2503251f78baa2fde0ce4351bf936d@epcas1p4.samsung.com>
2020-09-09  7:56 ` Tetsuhiro Kohada
2020-09-12  5:01   ` Sungjong Seo
2020-09-16  5:35     ` Tetsuhiro Kohada
2020-09-25  0:56       ` Sungjong Seo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='711c01d692d6$bc389610$34a9c230$@samsung.com' \
    --to=sj1557.seo@samsung.com \
    --cc=kohada.t2@gmail.com \
    --cc=kohada.tetsuhiro@dc.mitsubishielectric.co.jp \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mori.takahiro@ab.mitsubishielectric.co.jp \
    --cc=motai.hirotaka@aj.mitsubishielectric.co.jp \
    --cc=namjae.jeon@samsung.com \
    --subject='RE: [PATCH] exfat: remove '\''rwoffset'\'' in exfat_inode_info' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).