Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Christoph Hellwig <hch@lst.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Jeremy Kerr <jk@ozlabs.org>, Arnd Bergmann <arnd@arndb.de>,
	Oleg Nesterov <oleg@redhat.com>,
	the arch/x86 maintainers <x86@kernel.org>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: remove set_fs calls from the coredump code v6
Date: Wed, 06 May 2020 10:44:07 -0500	[thread overview]
Message-ID: <87lfm5cblk.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <20200506063134.GA11391@lst.de> (Christoph Hellwig's message of "Wed, 6 May 2020 08:31:34 +0200")

Christoph Hellwig <hch@lst.de> writes:

> On Tue, May 05, 2020 at 03:28:50PM -0500, Eric W. Biederman wrote:
>> We probably can.   After introducing a kernel_compat_siginfo that is
>> the size that userspace actually would need.
>> 
>> It isn't something I want to mess with until this code gets merged, as I
>> think the set_fs cleanups are more important.
>> 
>> 
>> Christoph made some good points about how ugly the #ifdefs are in
>> the generic copy_siginfo_to_user32 implementation.
>
> Take a look at the series you are replying to, the magic x86 ifdefs are
> entirely gone from the common code :)

Interesting.

That is a different way of achieving that, and I don't hate it.
  
I still want whatever you are doing to settle before I touch that code
again.  Removing the set_fs is important and I have other fish to fry
at the moment.

Eric




  reply	other threads:[~2020-05-06 15:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-05 10:12 remove set_fs calls from the coredump code v6 Christoph Hellwig
2020-05-05 10:12 ` [PATCH 1/7] powerpc/spufs: fix copy_to_user while atomic Christoph Hellwig
2020-05-05 10:12 ` [PATCH 2/7] powerpc/spufs: stop using access_ok Christoph Hellwig
2020-05-05 10:12 ` [PATCH 3/7] powerpc/spufs: simplify spufs core dumping Christoph Hellwig
2020-05-05 10:12 ` [PATCH 4/7] signal: refactor copy_siginfo_to_user32 Christoph Hellwig
2020-05-05 10:12 ` [PATCH 5/7] binfmt_elf: remove the set_fs in fill_siginfo_note Christoph Hellwig
2020-05-05 10:12 ` [PATCH 6/7] binfmt_elf: remove the set_fs(KERNEL_DS) in elf_core_dump Christoph Hellwig
2020-05-05 10:12 ` [PATCH 7/7] binfmt_elf_fdpic: remove the set_fs(KERNEL_DS) in elf_fdpic_core_dump Christoph Hellwig
2020-05-05 16:52 ` remove set_fs calls from the coredump code v6 Linus Torvalds
2020-05-05 20:28   ` Eric W. Biederman
2020-05-06  6:31     ` Christoph Hellwig
2020-05-06 15:44       ` Eric W. Biederman [this message]
2020-05-05 20:34 ` Al Viro
2020-05-05 20:42   ` Christoph Hellwig
2020-05-05 20:47     ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfm5cblk.fsf@x220.int.ebiederm.org \
    --to=ebiederm@xmission.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=hch@lst.de \
    --cc=jk@ozlabs.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=oleg@redhat.com \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).