Linux-Fsdevel Archive on
help / color / mirror / Atom feed
From: Markus Elfring <>
To: Dan Carpenter <>,
	Namjae Jeon <>,
	Sungjong Seo <>,
	Tetsuhiro Kohada <>
Subject: Re: [PATCH] exfat: Fix use after free in exfat_load_upcase_table()
Date: Mon, 8 Jun 2020 17:07:33 +0200	[thread overview]
Message-ID: <> (raw)

> This code calls brelse(bh) and then dereferences "bh" on the next line
> resulting in a possible use after free.

There is an unfortunate function call sequence.

> The brelse() should just be moved down a line.

How do you think about a wording variant like the following?

   Thus move a call of the function “brelse” one line down.

Would you like to omit a word from the patch subject so that
a typo will be avoided there?


             reply	other threads:[~2020-06-08 15:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-08 15:07 Markus Elfring [this message]
2020-06-08 15:52 ` Matthew Wilcox
2020-06-08 20:07   ` Markus Elfring
2020-06-09  9:10 ` [PATCH] " Greg KH
2020-06-10  9:27 ` exfat: Improving exception handling in two functions Markus Elfring
2020-06-10  9:59   ` [PATCH] exfat: call brelse() on error path Dan Carpenter
2020-06-10 12:14   ` exfat: Improving exception handling in two functions Markus Elfring
2020-06-10 14:53   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] exfat: Fix use after free in exfat_load_upcase_table()' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).