Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Dan Carpenter <dan.carpenter@oracle.com>, linux-fsdevel@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	Namjae Jeon <namjae.jeon@samsung.com>,
	Sungjong Seo <sj1557.seo@samsung.com>,
	Tetsuhiro Kohada <kohada.t2@gmail.com>
Subject: Re: [PATCH] exfat: Fix use after free in exfat_load_upcase_table()
Date: Mon, 8 Jun 2020 17:07:33 +0200	[thread overview]
Message-ID: <9b9272fb-b265-010b-0696-4c0579abd841@web.de> (raw)

> This code calls brelse(bh) and then dereferences "bh" on the next line
> resulting in a possible use after free.

There is an unfortunate function call sequence.


> The brelse() should just be moved down a line.

How do you think about a wording variant like the following?

   Thus move a call of the function “brelse” one line down.


Would you like to omit a word from the patch subject so that
a typo will be avoided there?

Regards,
Markus

             reply	other threads:[~2020-06-08 15:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-08 15:07 Markus Elfring [this message]
2020-06-08 15:52 ` Matthew Wilcox
2020-06-08 20:07   ` Markus Elfring
2020-06-09  9:10 ` [PATCH] " Greg KH
2020-06-10  9:27 ` exfat: Improving exception handling in two functions Markus Elfring
2020-06-10  9:59   ` [PATCH] exfat: call brelse() on error path Dan Carpenter
2020-06-10 12:14   ` exfat: Improving exception handling in two functions Markus Elfring
2020-06-10 14:53   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b9272fb-b265-010b-0696-4c0579abd841@web.de \
    --to=markus.elfring@web.de \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kohada.t2@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namjae.jeon@samsung.com \
    --cc=sj1557.seo@samsung.com \
    --subject='Re: [PATCH] exfat: Fix use after free in exfat_load_upcase_table()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).