Linux-Fsdevel Archive on
help / color / mirror / Atom feed
From: Linus Torvalds <>
To: Christoph Hellwig <>
Cc: Andrew Morton <>,
	Alexander Viro <>,
	Jeremy Kerr <>, Arnd Bergmann <>,
	Oleg Nesterov <>,
	"Eric W . Biederman" <>,
	"the arch/x86 maintainers" <>,
	linuxppc-dev <>,
	linux-fsdevel <>,
	Linux Kernel Mailing List <>
Subject: Re: remove set_fs calls from the coredump code v6
Date: Tue, 5 May 2020 09:52:04 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, May 5, 2020 at 3:13 AM Christoph Hellwig <> wrote:
> this series gets rid of playing with the address limit in the exec and
> coredump code.  Most of this was fairly trivial, the biggest changes are
> those to the spufs coredump code.

Ack, nice, and looks good.

The only part I dislike is how we have that 'struct compat_siginfo' on
the stack, which is a huge waste (most of it is the nasty padding to
128 bytes).

But that's not new, I only reacted to it because the code moved a bit.
We cleaned up the regular siginfo to not have the padding in the
kernel (and by "we" I mean "Eric Biederman did it after some prodding
as part of his siginfo cleanups" - see commit 4ce5f9c9e754 "signal:
Use a smaller struct siginfo in the kernel"),  and I wonder if we
could do something similar with that compat thing.

128 bytes of wasted kernel stack isn't the end of the world, but it's
sad when the *actual* data is only 32 bytes or so.


  parent reply	other threads:[~2020-05-05 16:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-05 10:12 Christoph Hellwig
2020-05-05 10:12 ` [PATCH 1/7] powerpc/spufs: fix copy_to_user while atomic Christoph Hellwig
2020-05-05 10:12 ` [PATCH 2/7] powerpc/spufs: stop using access_ok Christoph Hellwig
2020-05-05 10:12 ` [PATCH 3/7] powerpc/spufs: simplify spufs core dumping Christoph Hellwig
2020-05-05 10:12 ` [PATCH 4/7] signal: refactor copy_siginfo_to_user32 Christoph Hellwig
2020-05-05 10:12 ` [PATCH 5/7] binfmt_elf: remove the set_fs in fill_siginfo_note Christoph Hellwig
2020-05-05 10:12 ` [PATCH 6/7] binfmt_elf: remove the set_fs(KERNEL_DS) in elf_core_dump Christoph Hellwig
2020-05-05 10:12 ` [PATCH 7/7] binfmt_elf_fdpic: remove the set_fs(KERNEL_DS) in elf_fdpic_core_dump Christoph Hellwig
2020-05-05 16:52 ` Linus Torvalds [this message]
2020-05-05 20:28   ` remove set_fs calls from the coredump code v6 Eric W. Biederman
2020-05-06  6:31     ` Christoph Hellwig
2020-05-06 15:44       ` Eric W. Biederman
2020-05-05 20:34 ` Al Viro
2020-05-05 20:42   ` Christoph Hellwig
2020-05-05 20:47     ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: remove set_fs calls from the coredump code v6' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).