Linux-Fsdevel Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Al Viro <viro@zeniv.linux.org.uk>, Ian Kent <raven@themaw.net>,
David Howells <dhowells@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
LSM List <linux-security-module@vger.kernel.org>,
NetFilter <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH 10/13] integrity/ima: switch to using __kernel_read
Date: Mon, 15 Jun 2020 09:46:12 -0700 [thread overview]
Message-ID: <CAHk-=wiBJjjV4NuKr_z2Q3vWEXSoGtAmkH=jZ0SkBJ=wZh4=hw@mail.gmail.com> (raw)
In-Reply-To: <20200615121257.798894-11-hch@lst.de>
On Mon, Jun 15, 2020 at 5:13 AM Christoph Hellwig <hch@lst.de> wrote:
>
> __kernel_read has a bunch of additional sanity checks, and this moves
> the set_fs out of non-core code.
Wel, you also seem to be removing this part:
> - if (!(file->f_mode & FMODE_READ))
> - return -EBADF;
which you didn't add in the previous patch that implemented __kernel_read().
It worries me that you're making these kinds of transformations where
the comments imply it's a no-op, but the actual code doesn't agree.
Especially when it's part of one large patch series and each commit
looks trivial.
This kind of series needs more care. Maybe that test isn't necessary,
but it isn't obvious, and I really don't like how you completely
glossed over totally changing what the code did.
Linus
next prev parent reply other threads:[~2020-06-15 16:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 12:12 clean up kernel_{read,write} & friends v4 Christoph Hellwig
2020-06-15 12:12 ` [PATCH 01/13] cachefiles: switch to kernel_write Christoph Hellwig
2020-06-15 12:12 ` [PATCH 02/13] autofs: " Christoph Hellwig
2020-06-15 12:12 ` [PATCH 03/13] bpfilter: " Christoph Hellwig
2020-06-15 12:12 ` [PATCH 04/13] fs: unexport __kernel_write Christoph Hellwig
2020-06-15 12:12 ` [PATCH 05/13] fs: check FMODE_WRITE in __kernel_write Christoph Hellwig
2020-06-15 12:34 ` Matthew Wilcox
2020-06-15 13:48 ` Christoph Hellwig
2020-06-15 16:39 ` Linus Torvalds
2020-06-15 16:42 ` Christoph Hellwig
2020-06-17 14:59 ` David Laight
2020-06-15 12:12 ` [PATCH 06/13] fs: implement kernel_write using __kernel_write Christoph Hellwig
2020-06-15 12:12 ` [PATCH 07/13] fs: remove __vfs_write Christoph Hellwig
2020-06-15 12:12 ` [PATCH 08/13] fs: don't change the address limit for ->write_iter in __kernel_write Christoph Hellwig
2020-06-15 12:12 ` [PATCH 09/13] fs: add a __kernel_read helper Christoph Hellwig
2020-06-15 12:12 ` [PATCH 10/13] integrity/ima: switch to using __kernel_read Christoph Hellwig
2020-06-15 16:46 ` Linus Torvalds [this message]
2020-06-15 16:56 ` Linus Torvalds
2020-06-15 12:12 ` [PATCH 11/13] fs: implement kernel_read " Christoph Hellwig
2020-06-15 12:12 ` [PATCH 12/13] fs: remove __vfs_read Christoph Hellwig
2020-06-15 12:12 ` [PATCH 13/13] fs: don't change the address limit for ->read_iter in __kernel_read Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wiBJjjV4NuKr_z2Q3vWEXSoGtAmkH=jZ0SkBJ=wZh4=hw@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=raven@themaw.net \
--cc=viro@zeniv.linux.org.uk \
--subject='Re: [PATCH 10/13] integrity/ima: switch to using __kernel_read' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).